Update PodDisruptionBudget API version for Kubernetes 1.25 #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Beta API version (policy/v1beta1) of PodDisruptionBudget is no longer served as of version 1.25
|
I am taking over PR #723 which had outstanding comments that had not been resolved. I am currently blocked and unable to deploy the |
igreg
changed the title
|
@BennettJames Would you be able to help with this PR? I saw you commented on the PR I'm taking over. |
BennettJames
approved these changes
Dec 18, 2023
|
Hey Greg, This looks good; I added an approval. I'll merge it once the build succeeds. |
|
Thanks @BennettJames. Sorry, I merged the master into the PR after the build had succeeded believing this would help but didn't realize the workflows were also requiring approval so it's awaiting your approval again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
The Beta API version (policy/v1beta1) of PodDisruptionBudget is no longer served as of version 1.25.
cf. https://cloud.google.com/kubernetes-engine/docs/deprecations/apis-1-25
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.