-
Notifications
You must be signed in to change notification settings - Fork 924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New serverless pattern - SQS-EventBus using EventBridge Pipes #2466
Open
chaitanyagummadi
wants to merge
3
commits into
aws-samples:main
Choose a base branch
from
chaitanyagummadi:chaitanyagummadi-feature-eventbridge-pipes-sqs-to-eventbus-terraform
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfreiberg
requested changes
Sep 10, 2024
eventbridge-pipes-sqs-to-eventbus-terraform/example-pattern.json
Outdated
Show resolved
Hide resolved
Hi, do you still plan to address the requested changes? |
chaitanyagummadi
force-pushed
the
chaitanyagummadi-feature-eventbridge-pipes-sqs-to-eventbus-terraform
branch
from
October 20, 2024 21:15
fce7693
to
65151f2
Compare
chaitanyagummadi
force-pushed
the
chaitanyagummadi-feature-eventbridge-pipes-sqs-to-eventbus-terraform
branch
from
October 20, 2024 21:35
bfd26c9
to
3afef3a
Compare
I have implemented the requested changes and squashed the commits to make it cleaner. |
bfreiberg
requested changes
Oct 24, 2024
eventbridge-pipes-sqs-to-eventbus-terraform/example-pattern.json
Outdated
Show resolved
Hide resolved
eventbridge-pipes-sqs-to-eventbus-terraform/example-pattern.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Ben <[email protected]>
Co-authored-by: Ben <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#2467
Description of changes:
This pattern establishes an EventBridge Pipe that retrieves messages from an Amazon Simple Queue Service (SQS) queue and sends the events to a Custom EventBus within Amazon EventBridge.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.