New serverless pattern - Lambda Recycle Bin #2463

Divya-Vijendra-Girase · 2024-09-02T15:09:43Z

Issue #2464:

Description of changes:
In this pattern an Amazon EventBridge trigger AWS Lambda function to deregister AMI, delete the associated snapshot and move them to Recycle Bin for retention. The infrastructure is in terraform

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

bfreiberg · 2024-09-10T18:39:56Z

Thank you for submitting this request. Your PR does not adhere to our publishing guidelines. It is missing the example-pattern.json file for example. Additionally, please check in any source code in an unzipped format.

Divya-Vijendra-Girase · 2024-09-11T14:34:44Z

Thank you for submitting this request. Your PR does not adhere to our publishing guidelines. It is missing the example-pattern.json file for example. Additionally, please check in any source code in an unzipped format.

Thank you for the review.
Added example-pattern.json

ami-recycle-bin/README.md

bfreiberg · 2024-09-12T07:07:41Z

ami-recycle-bin/example-pattern.json

@@ -0,0 +1,55 @@
+{
+    "title": "Deregister expired AMIs and its snapshot with AWS Lambda and retain them in Amazon EC2 Recycle Bin",


The title can have at most 75 characters, please reword

The title can have at most 75 characters, please reword

Updated title to 75 characters AMI de-registration with AWS Lambda and retention in Amazon EC2 Recycle Bin

bfreiberg · 2024-09-12T07:07:58Z

ami-recycle-bin/example-pattern.json

+{
+    "title": "Deregister expired AMIs and its snapshot with AWS Lambda and retain them in Amazon EC2 Recycle Bin",
+    "description": "This project demonstrates a pattern to deregister and retain expired AMI and its snapshot with AWS Lambda and Amazon EC2 Recycle Bin",
+    "language": "YAML",


You can leave this property empty for Terraform

You can leave this property empty for Terraform

Updated the language property value to be an empty string

bfreiberg · 2024-09-12T07:11:03Z

ami-recycle-bin/README.md

@@ -0,0 +1,85 @@
+## Description
+
+In this pattern an Amazon EventBridge trigger AWS Lambda function to deregister AMI, delete the associated snapshot and move them to Recycle Bin for retention.


Suggested change

In this pattern an Amazon EventBridge trigger AWS Lambda function to deregister AMI, delete the associated snapshot and move them to Recycle Bin for retention.

In this pattern an Amazon EventBridge rule triggers an AWS Lambda function which deregisters an Amazon Machine Image (AMI), deletes the associated snapshot and moves them to the Recycle Bin for retention.

Updated as per the suggested changes

bfreiberg · 2024-09-12T07:12:52Z

ami-recycle-bin/README.md

+
+The template creates all the necessary resources including an Amazon EventBridge Rule that triggers the AWS Lambda function once every day. Additionally, Recycle Bin rules for AMI and EBS Snapshots are created to retain deleted resources matching the resources for a retention period.
+
+AWS Lambda function automates the expiration of Amazon Machine Images (AMIs) moving the AMIs and its associated snapshot to Recycle Bin af. The Recycle Bin is a feature in Amazon Elastic Compute Cloud (EC2) that allows you to retain AMIs that you have deregistered for a specified retention period, providing an opportunity to recover them if needed. To recover the deleted AMI, its associated snapshot should be recovered first. The lambda function also adds corresponding tags to both, the AMI and the EBS Snapshot before moving them to Recyle Bin for recovery.


Suggested change

AWS Lambda function automates the expiration of Amazon Machine Images (AMIs) moving the AMIs and its associated snapshot to Recycle Bin af. The Recycle Bin is a feature in Amazon Elastic Compute Cloud (EC2) that allows you to retain AMIs that you have deregistered for a specified retention period, providing an opportunity to recover them if needed. To recover the deleted AMI, its associated snapshot should be recovered first. The lambda function also adds corresponding tags to both, the AMI and the EBS Snapshot before moving them to Recyle Bin for recovery.

The AWS Lambda function automates the expiration of Amazon Machine Images (AMIs) by moving the AMIs and their associated snapshots to Recycle Bin. Recycle Bin is a feature of Amazon Elastic Compute Cloud (EC2) that allows you to retain AMIs that you have de-registered for a specified retention period, providing an opportunity to recover them if needed. To recover the deleted AMI, its associated snapshot should be recovered first. The Lambda function also adds corresponding tags to both, the AMI and the EBS snapshot, before moving them to Recycle Bin.

Updated as per the suggested changes

bfreiberg · 2024-09-12T07:14:13Z

ami-recycle-bin/main.tf

+
+resource "aws_cloudwatch_event_rule" "event_rule" {
+  name                = "invoke-lambda-daily"
+  description         = "Invoke a Lambda function every day"


Suggested change

description = "Invoke a Lambda function every day"

description = "Invoke a Lambda function once per day"

Updated description to Invoke a Lambda function once per day

bfreiberg · 2024-09-12T07:15:32Z

ami-recycle-bin/main.tf

+  function_name    = "ami-recycle-lambda"
+  role             = aws_iam_role.lambda_role.arn
+  handler          = "ami-recycle-lambda.lambda_handler"
+  runtime          = "python3.9"


Please use the most recent Python version

Please use the most recent Python version

Used the most recent supported version python3.12

bfreiberg · 2024-09-12T07:15:51Z

ami-recycle-bin/main.tf

+      "RBIN_RETENTION_PERIOD_UNIT" = var.rbin_retention_period_unit
+    }
+  }
+  timeout          = 300


Is such a long timeout really necessary?

Is such a long timeout really necessary?

If the list of expired AMIs is long, the maximum timeout will be helpful to ensure function does not timeout before the expired AMIs and its snapshot is moved to Recycle Bin. However since this is a test pattern, updated the timeout parameter as a configurable variable and set the default timeout to 15 seconds

bfreiberg · 2024-09-12T07:16:15Z

ami-recycle-bin/main.tf

+            "logs:PutLogEvents",
+            "logs:CreateLogGroup"
+          ]
+          Resource = "arn:aws:logs:*:*:*"


Please scope the policy down to the current account and region

Please scope the policy down to the current account and region

Added data.tf file to add data source and scoped down the policy to

region and account for CreateLogGroup

region, account and function name for CreateLogStream and PutLogEvents

bfreiberg · 2024-09-12T07:16:19Z

ami-recycle-bin/main.tf

+            "ec2:DeleteSnapshot",
+            "rbin:ListRules"
+          ]
+          Resource = "*" 


Please scope the policy down to the current account and region

Please scope the policy down to the current account and region

Scoped down policy for the actions that can be restricted to resources like DeregisterImage and DeleteSnapshot

Updated policy statement to separate actions that only support wildcard - DescribeImages and ListRules

Divya-Vijendra-Girase · 2024-09-24T20:27:37Z

Hi team - Updated the content as per the feedback. Can you please review this. Thank you!

bfreiberg · 2024-09-27T12:24:11Z

Hi, thanks for the updates. Could please check in the Lambda function code in an unzipped format to allow a review

Divya-Vijendra-Girase · 2024-09-27T14:03:18Z

Hi, thanks for the updates. Could please check in the Lambda function code in an unzipped format to allow a review

Thank you - Added the source code.

bfreiberg · 2024-10-08T07:37:59Z

Looks good, thanks for your contribution. Your pattern will be merged to Serverlessland.com soon

New serverless pattern - Lambda Recycle Bin

4a75210

julianwood assigned bfreiberg and julianwood Sep 2, 2024

Divya-Vijendra-Girase mentioned this pull request Sep 2, 2024

New pattern submission: Retain Expired AMI and its Snapshot with AWS Lambda and Amazon EC2 Recycle Bin #2464

Open

Added example-pattern.json

a70334a

bfreiberg requested changes Sep 12, 2024

View reviewed changes

divyavigirase added 2 commits September 12, 2024 11:55

Updated as per the review feedback

5f9fc25

Updated README.md and example-pattern.json as per the review comments

94014c8

Divya-Vijendra-Girase requested a review from bfreiberg September 17, 2024 11:36

Added source code for ami deregistration

7dd137f

Add final pattern file

3bdfa25

bfreiberg added the Patterns Guardian approved label Oct 8, 2024

bfreiberg approved these changes Oct 8, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New serverless pattern - Lambda Recycle Bin #2463

New serverless pattern - Lambda Recycle Bin #2463

Divya-Vijendra-Girase commented Sep 2, 2024 •

edited

Loading

bfreiberg commented Sep 10, 2024

Divya-Vijendra-Girase commented Sep 11, 2024

bfreiberg Sep 12, 2024

Divya-Vijendra-Girase Sep 12, 2024

bfreiberg Sep 12, 2024

Divya-Vijendra-Girase Sep 12, 2024

bfreiberg Sep 12, 2024

Divya-Vijendra-Girase Sep 12, 2024

bfreiberg Sep 12, 2024

Divya-Vijendra-Girase Sep 12, 2024

bfreiberg Sep 12, 2024

Divya-Vijendra-Girase Sep 12, 2024

bfreiberg Sep 12, 2024

Divya-Vijendra-Girase Sep 12, 2024

bfreiberg Sep 12, 2024

Divya-Vijendra-Girase Sep 12, 2024

bfreiberg Sep 12, 2024

Divya-Vijendra-Girase Sep 12, 2024

bfreiberg Sep 12, 2024

Divya-Vijendra-Girase Sep 12, 2024

Divya-Vijendra-Girase commented Sep 24, 2024

bfreiberg commented Sep 27, 2024

Divya-Vijendra-Girase commented Sep 27, 2024

bfreiberg commented Oct 8, 2024

		@@ -0,0 +1,55 @@
		{
		"title": "Deregister expired AMIs and its snapshot with AWS Lambda and retain them in Amazon EC2 Recycle Bin",

		@@ -0,0 +1,85 @@
		## Description

		In this pattern an Amazon EventBridge trigger AWS Lambda function to deregister AMI, delete the associated snapshot and move them to Recycle Bin for retention.

	In this pattern an Amazon EventBridge trigger AWS Lambda function to deregister AMI, delete the associated snapshot and move them to Recycle Bin for retention.
	In this pattern an Amazon EventBridge rule triggers an AWS Lambda function which deregisters an Amazon Machine Image (AMI), deletes the associated snapshot and moves them to the Recycle Bin for retention.


		The template creates all the necessary resources including an Amazon EventBridge Rule that triggers the AWS Lambda function once every day. Additionally, Recycle Bin rules for AMI and EBS Snapshots are created to retain deleted resources matching the resources for a retention period.

		AWS Lambda function automates the expiration of Amazon Machine Images (AMIs) moving the AMIs and its associated snapshot to Recycle Bin af. The Recycle Bin is a feature in Amazon Elastic Compute Cloud (EC2) that allows you to retain AMIs that you have deregistered for a specified retention period, providing an opportunity to recover them if needed. To recover the deleted AMI, its associated snapshot should be recovered first. The lambda function also adds corresponding tags to both, the AMI and the EBS Snapshot before moving them to Recyle Bin for recovery.

	description = "Invoke a Lambda function every day"
	description = "Invoke a Lambda function once per day"

New serverless pattern - Lambda Recycle Bin #2463

Are you sure you want to change the base?

New serverless pattern - Lambda Recycle Bin #2463

Conversation

Divya-Vijendra-Girase commented Sep 2, 2024 • edited Loading

bfreiberg commented Sep 10, 2024

Divya-Vijendra-Girase commented Sep 11, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Divya-Vijendra-Girase commented Sep 24, 2024

bfreiberg commented Sep 27, 2024

Divya-Vijendra-Girase commented Sep 27, 2024

bfreiberg commented Oct 8, 2024

Divya-Vijendra-Girase commented Sep 2, 2024 •

edited

Loading