Skip to content

Commit

Permalink
Fix wrong argument passed to updateTerminationProtection function (#1197
Browse files Browse the repository at this point in the history
)

The updateTerminationProtection function is getting a wrong argument "stack.id" which resulting the termination protection for stack not lifted and deletion of stack fail.
  • Loading branch information
vic614 authored Nov 30, 2023
1 parent 3ff53c9 commit f93a132
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/deployments/cdk/toolkit.ts
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ export class CdkToolkit {
this.deploymentLog(stack, 'Disabling termination protection');
await cfn
.updateTerminationProtection({
StackName: stack.id,
StackName: stack.stackName,
EnableTerminationProtection: false,
})
.promise();
Expand Down Expand Up @@ -352,7 +352,7 @@ export class CdkToolkit {
this.deploymentLog(stack, 'Disabling termination protection');
await cfn
.updateTerminationProtection({
StackName: stack.id,
StackName: stack.stackName,
EnableTerminationProtection: false,
})
.promise();
Expand Down

0 comments on commit f93a132

Please sign in to comment.