Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm_xml: set_vm_vcpus() support clusters #4006

Merged

Conversation

rh-jugraham
Copy link
Contributor

@rh-jugraham rh-jugraham commented Sep 26, 2024

Signed-off-by: Julia Graham [email protected]

Modified set_vm_vcpus() to support clusters.

@rh-jugraham
Copy link
Contributor Author

Tested implementation on max_vcpus_topology.py (passing tests shown in mentioned PR), topology.py, and virsh_guestvcpus.py.

Passing topology.py test:

[root@beaver-6 /]# /usr/local/bin/avocado run --vt-type libvirt --vt-machine-type q35 topology.positive.hotplug --vt-connect-uri qemu:///system
No python imaging library installed. Screendump and Windows guest BSOD detection are disabled. In order to enable it, please install python-imaging or the equivalent for your distro.
No python imaging library installed. PPM image conversion to JPEG disabled. In order to enable it, please install python-imaging or the equivalent for your distro.
JOB ID : dbc5eb5bdca4fce9083f3aa018ad23e6ee229974
JOB LOG : /var/log/avocado/job-results/job-2024-09-27T20.39-dbc5eb5/job.log
(1/1) type_specific.io-github-autotest-libvirt.topology.positive.hotplug: STARTED
(1/1) type_specific.io-github-autotest-libvirt.topology.positive.hotplug: PASS (63.12 s)
RESULTS : PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML : /var/log/avocado/job-results/job-2024-09-27T20.39-dbc5eb5/results.html
JOB TIME : 64.50 s

Passing virsh_guestvcpus.py tests:

[root@beaver-6 /]# /usr/local/bin/avocado run --vt-type libvirt --vt-machine-type q35 virsh.guestvcpus.normal_test --vt-connect-uri qemu:///system
No python imaging library installed. Screendump and Windows guest BSOD detection are disabled. In order to enable it, please install python-imaging or the equivalent for your distro.
No python imaging library installed. PPM image conversion to JPEG disabled. In order to enable it, please install python-imaging or the equivalent for your distro.
JOB ID : 547140c73da49ce1f7300d99c91b0bbef651bac7
JOB LOG : /var/log/avocado/job-results/job-2024-09-27T20.43-547140c/job.log
(1/4) type_specific.io-github-autotest-libvirt.virsh.guestvcpus.normal_test.no-option: STARTED
(1/4) type_specific.io-github-autotest-libvirt.virsh.guestvcpus.normal_test.no-option: PASS (532.89 s)
(2/4) type_specific.io-github-autotest-libvirt.virsh.guestvcpus.normal_test.disable: STARTED
(2/4) type_specific.io-github-autotest-libvirt.virsh.guestvcpus.normal_test.disable: PASS (199.89 s)
(3/4) type_specific.io-github-autotest-libvirt.virsh.guestvcpus.normal_test.enable: STARTED
(3/4) type_specific.io-github-autotest-libvirt.virsh.guestvcpus.normal_test.enable: PASS (186.87 s)
(4/4) type_specific.io-github-autotest-libvirt.virsh.guestvcpus.normal_test.combine: STARTED
(4/4) type_specific.io-github-autotest-libvirt.virsh.guestvcpus.normal_test.combine: PASS (187.81 s)
RESULTS : PASS 4 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML : /var/log/avocado/job-results/job-2024-09-27T20.43-547140c/results.html
JOB TIME : 1110.68 s

@rh-jugraham rh-jugraham marked this pull request as ready for review September 28, 2024 01:10
@Yingshun
Copy link
Contributor

Yingshun commented Oct 8, 2024

@rh-jugraham Plz fix the error in signedoff-check, thx!

@rh-jugraham rh-jugraham force-pushed the set_vm_vcpus_clusters branch 2 times, most recently from 0c511cc to e377734 Compare October 8, 2024 15:14
@rh-jugraham
Copy link
Contributor Author

@rh-jugraham Plz fix the error in signedoff-check, thx!

Updated the commit message!

@Yingshun
Copy link
Contributor

Yingshun commented Oct 9, 2024

@rh-jugraham Plz fix the error in signedoff-check, thx!

Updated the commit message!

There is one more failure in static check, plz resolve it, thx!

@rh-jugraham
Copy link
Contributor Author

There is one more failure in static check, plz resolve it, thx!

Updated! I don't have the permissions to rerun the workflow but I fixed the issue I saw

@Yingshun Yingshun merged commit 7d009bb into avocado-framework:master Oct 11, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants