Add support for newer floppy device after Qemu 5.1.0

[pevogam]

We keep compatibility with old floppy devices but add the new floppy support to re-enable unattended installs of older windows machines.

[pevogam]

This pull request will close #3429 once reviewed, fully tested, and merged.

[pevogam]

@luckyh @PaulYuuu This pull request hasn't been tested yet and the current is only an initial push where I would appreciate a generic superficial review that focuses on whether I use the correct QDevice instantiation. So far I mostly guessed all of this looking at the API but if this is a good direction and you don't have any big recommendation I will test this with both older and newer Qemu version next. Any feedback on my guesswork is highly appreciated.

[luckyh]

Hi @pevogam , thank you for fixing the issue! However, I have some concerns regarding the current approach.

[pevogam]

Alright, I tested this with Qemu 5.1.0 and so far it looks good, @luckyh let me know if it addresses your concerns.

[pevogam]

Hi @luckyh I integrated your change and tested this functionally but the CI keeps failing even after rebase. The only problems I see there (other than numberous info messages) are of the types:

/home/runner/work/avocado-vt/avocado-vt/virttest/cartesian_config.py:1815:32: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
...
/home/runner/work/avocado-vt/avocado-vt/virttest/unittest_utils/mock.py:59:16: E721

Do you happen to know if the CI currently passes on the master branch? I don't see how we would have changed anything regarding the unittest_utils or the cartesian_config above.

[luckyh]

Do you happen to know if the CI currently passes on the master branch? I don't see how we would have changed anything regarding the unittest_utils or the cartesian_config above.

@pevogam looks the issue has already been fixed by #3734 , so would you please try to rebase the code and push it one more time? thanks!

[pevogam]

Do you happen to know if the CI currently passes on the master branch? I don't see how we would have changed anything regarding the unittest_utils or the cartesian_config above.

@pevogam looks the issue has already been fixed by #3734 , so would you please try to rebase the code and push it one more time? thanks!

Alright done and static checks are now passing.

[luckyh]

LGTM

[luckyh]

@YongxueHong would you mind to review this PR? thanks!

[YongxueHong]

LGTM.

[YongxueHong]

@luckyh @PaulYuuu This pull request hasn't been tested yet and the current is only an initial push where I would appreciate a generic superficial review that focuses on whether I use the correct QDevice instantiation. So far I mostly guessed all of this looking at the API but if this is a good direction and you don't have any big recommendation I will test this with both older and newer Qemu version next. Any feedback on my guesswork is highly appreciated.

Hi @PaulYuuu
Would you mind reviewing this PR?
Thanks in advance.

[pevogam]

@luckyh @PaulYuuu This pull request hasn't been tested yet and the current is only an initial push where I would appreciate a generic superficial review that focuses on whether I use the correct QDevice instantiation. So far I mostly guessed all of this looking at the API but if this is a good direction and you don't have any big recommendation I will test this with both older and newer Qemu version next. Any feedback on my guesswork is highly appreciated.

Hi @PaulYuuu Would you mind reviewing this PR? Thanks in advance.

@PaulYuuu I have adapted your changes and tested them - everything works fine.