Skip to content

Commit

Permalink
Merge pull request #6030 from avalonmediasystem/default_manifest
Browse files Browse the repository at this point in the history
Provide default required metadata in IIIF Manifest
  • Loading branch information
masaball authored Sep 13, 2024
2 parents d5230b4 + c2e531f commit 130de66
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 2 deletions.
4 changes: 2 additions & 2 deletions app/models/iiif_manifest_presenter.rb
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def description
end

def to_s
media_object.title
media_object.title || media_object.id
end

def manifest_metadata
Expand Down Expand Up @@ -180,7 +180,7 @@ def display_lending_period(media_object)

def iiif_metadata_fields
fields = [
metadata_field('Title', media_object.title),
metadata_field('Title', media_object.title, media_object.id),
metadata_field('Date', combined_display_date(media_object), 'Not provided'),
metadata_field('Main contributor', media_object.creator),
metadata_field('Summary', display_summary(media_object)),
Expand Down
13 changes: 13 additions & 0 deletions spec/models/iiif_manifest_presenter_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,19 @@
let(:master_file) { FactoryBot.build(:master_file, media_object: media_object) }
let(:presenter) { described_class.new(media_object: media_object, master_files: [master_file]) }

context 'to_s' do
it "returns the media object's title" do
expect(presenter.to_s).to eq media_object.title
end

context 'when media object is missing title' do
it "returns the media object's id" do
allow(media_object).to receive(:title).and_return(nil)
expect(presenter.to_s).to eq media_object.id
end
end
end

context 'homepage' do
subject { presenter.homepage.first }

Expand Down

0 comments on commit 130de66

Please sign in to comment.