SRIOV: add new test scenarios for vIOMMU #5937
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automate new dma_translation attribute for vIOMMU: VIRT-294818 - [vIOMMU] Hotplug or coldplug iommu device to guest VIRT-294818 - [vIOMMU] Start vm with iommu device Signed-off-by: Meina Li <[email protected]>
|
chunfuwen
reviewed
Oct 15, 2024
| @@ -33,6 +33,8 @@ def run(test, params, env): | |||
| vmxml.features = features | |||
| vmxml.sync() | |||
| err_msg = '' | |||
| if libvirt_version.version_compare(10, 7, 0) and iommu_dict['model'] == 'intel': | |||
| iommu_dict['driver']['dma_translation'] = 'on' | |||
There was a problem hiding this comment.
dma_translation is new feature, so maybe create separate case under intel variant of ./libvirt/tests/cfg/sriov/vIOMMU/attach_iommu_device.cfg , otherwise it is easy to ignore this feature if still under previous test case.
There was a problem hiding this comment.
I've considered whether we need to add a new case. But after the evaluation I gave up because:
- Keep the same attributes strategy as before in plan.
- This new attribute is not so important because before it was enabled default.
Certainly it can also reduce our debug workloads.
|
@Yingshun Could you help review this PR? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automate new dma_translation attribute for vIOMMU:
VIRT-294818 - [vIOMMU] Hotplug or coldplug iommu device to guest
VIRT-294818 - [vIOMMU] Start vm with iommu device