-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SRIOV: add new test scenarios for vIOMMU #5937
base: master
Are you sure you want to change the base?
Conversation
Automate new dma_translation attribute for vIOMMU: VIRT-294818 - [vIOMMU] Hotplug or coldplug iommu device to guest VIRT-294818 - [vIOMMU] Start vm with iommu device Signed-off-by: Meina Li <[email protected]>
|
@@ -33,6 +33,8 @@ def run(test, params, env): | |||
vmxml.features = features | |||
vmxml.sync() | |||
err_msg = '' | |||
if libvirt_version.version_compare(10, 7, 0) and iommu_dict['model'] == 'intel': | |||
iommu_dict['driver']['dma_translation'] = 'on' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dma_translation is new feature, so maybe create separate case under intel variant of ./libvirt/tests/cfg/sriov/vIOMMU/attach_iommu_device.cfg , otherwise it is easy to ignore this feature if still under previous test case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've considered whether we need to add a new case. But after the evaluation I gave up because:
- Keep the same attributes strategy as before in plan.
- This new attribute is not so important because before it was enabled default.
Certainly it can also reduce our debug workloads.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@Yingshun Could you help review this PR? Thanks. |
Automate new dma_translation attribute for vIOMMU:
VIRT-294818 - [vIOMMU] Hotplug or coldplug iommu device to guest
VIRT-294818 - [vIOMMU] Start vm with iommu device