vcpu_metrics: handle missing element #5887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
JOB ID : 64645530355a1d88af3885a982a9e33a91c64e35 |
|
@liang-cong-red-hat please help review |
liang-cong-red-hat
suggested changes
Sep 10, 2024
| "loader_readonly": vmxml.os.loader_readonly, | ||
| "loader_type": vmxml.os.loader_type | ||
| } | ||
| vmxml.os = libvirt_bios.remove_bootconfig_items_from_vmos(vmxml.os) |
There was a problem hiding this comment.
libvirt_bios.remove_bootconfig_items_from_vmos could move out of try...except block.
//os/loader* might not exist on the domain definition leading to an exception. In this case, skip the step that tries to remove those attributes. Signed-off-by: Sebastian Mitterle <[email protected]>
smitterl
force-pushed
the
cpu_metric
branch
from
b996390
to
5d96e5a
Compare
cliping
approved these changes
Sep 18, 2024
chloerh
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
//os/loader* might not exist on the domain definition leading to an exception. In this case, skip the step that tries to remove those attributes.