-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RAS: add new case for RAS feature support #5811
Conversation
depends on avocado-framework/avocado-vt#3960 |
f518bf5
to
157f901
Compare
@xiaodwan plz upload test results, thx! |
157f901
to
5a70d5b
Compare
|
5a70d5b
to
29c71b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Others LGTM
libvirt/tests/src/features/ras.py
Outdated
features_xml = vm_xml.features | ||
if features_xml.has_feature('ras'): | ||
features_xml.remove_feature('ras') | ||
features_xml.ras = "%s" % ras_state |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can it be 'features_xml.ras = ras_state'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Signed-off-by: Xiaodai Wang <[email protected]>
29c71b2
to
c9b6c58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.