Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RAS: add new case for RAS feature support #5811

Merged
merged 1 commit into from
Oct 10, 2024
Merged

RAS: add new case for RAS feature support #5811

merged 1 commit into from
Oct 10, 2024
+77 −0

Conversation

xiaodwan
Copy link
Contributor

No description provided.

@xiaodwan
Copy link
Contributor Author

depends on avocado-framework/avocado-vt#3960

@xiaodwan xiaodwan added the depend on The PR has dependency on other PRs label Jul 26, 2024
@Yingshun
Copy link
Contributor

@xiaodwan plz upload test results, thx!

Yingshun
Yingshun reviewed Aug 27, 2024
View reviewed changes
libvirt/tests/cfg/features/ras.cfg Show resolved Hide resolved
libvirt/tests/src/features/ras.py Outdated Show resolved Hide resolved
libvirt/tests/src/features/ras.py Outdated Show resolved Hide resolved
libvirt/tests/src/features/ras.py Outdated Show resolved Hide resolved
@Yingshun Yingshun requested a review from dzhengfy August 27, 2024 09:55
dzhengfy
dzhengfy reviewed Aug 29, 2024
View reviewed changes
libvirt/tests/cfg/features/ras.cfg Show resolved Hide resolved
libvirt/tests/src/features/ras.py Show resolved Hide resolved
libvirt/tests/src/features/ras.py Outdated Show resolved Hide resolved
@xiaodwan
Copy link
Contributor Author

xiaodwan commented Sep 3, 2024 

JOB ID     : a5954ec4c75aadf4f5d9ee9f470e598d549851dd
JOB LOG    : /var/log/avocado/job-results/job-2024-09-03T02.11-a5954ec/job.log
 (1/2) type_specific.io-github-autotest-libvirt.features.ras.positive_test.on: STARTED
 (1/2) type_specific.io-github-autotest-libvirt.features.ras.positive_test.on: PASS (7.89 s)
 (2/2) type_specific.io-github-autotest-libvirt.features.ras.positive_test.on: STARTED
 (2/2) type_specific.io-github-autotest-libvirt.features.ras.positive_test.on: PASS (8.73 s)
RESULTS    : PASS 2 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML   : /var/log/avocado/job-results/job-2024-09-03T02.11-a5954ec/results.html
JOB TIME   : 18.33 s

JOB ID     : 7642ac7b241fed17949d7b7e8d5ca7e1bdc0f7fc
JOB LOG    : /var/log/avocado/job-results/job-2024-09-03T02.11-7642ac7/job.log
 (1/2) type_specific.io-github-autotest-libvirt.features.ras.positive_test.off: STARTED
 (1/2) type_specific.io-github-autotest-libvirt.features.ras.positive_test.off: PASS (7.93 s)
 (2/2) type_specific.io-github-autotest-libvirt.features.ras.positive_test.off: STARTED
 (2/2) type_specific.io-github-autotest-libvirt.features.ras.positive_test.off: PASS (8.75 s)
RESULTS    : PASS 2 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML   : /var/log/avocado/job-results/job-2024-09-03T02.11-7642ac7/results.html

Yingshun
Yingshun reviewed Sep 23, 2024
View reviewed changes
Copy link
Contributor

@Yingshun Yingshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM

libvirt/tests/src/features/ras.py Outdated Show resolved Hide resolved
libvirt/tests/src/features/ras.py Outdated
features_xml = vm_xml.features
if features_xml.has_feature('ras'):
features_xml.remove_feature('ras')
features_xml.ras = "%s" % ras_state
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it be 'features_xml.ras = ras_state'?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

dzhengfy
dzhengfy approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@dzhengfy dzhengfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dzhengfy dzhengfy merged commit 6fd65ed into autotest:master Oct 10, 2024
5 checks passed
@xiaodwan xiaodwan deleted the new_case_for_ras_support branch October 11, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzhengfy dzhengfy dzhengfy approved these changes

@Yingshun Yingshun Yingshun approved these changes

Assignees
No one assigned
Labels
depend on The PR has dependency on other PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiaodwan @Yingshun @dzhengfy