-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auto_memory_nodeset_placement: add case auto mem nodeset and placement #5039
auto_memory_nodeset_placement: add case auto mem nodeset and placement #5039
Conversation
libvirt 9.2.0
|
a414587
to
b394227
Compare
libvirt 8.0.0
|
21a36a7
to
80a2d2a
Compare
Signed-off-by: Dan Zheng <[email protected]>
80a2d2a
to
85b755c
Compare
@nanli1 could you help review it? thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
if vcpu_placement == 'static' and mem_mode == 'none': | ||
xpaths_text = [{'element_attrs': ["./numatune"]}] | ||
if libvirt_vmxml.check_guest_xml_by_xpaths(vmxml, xpaths_text, ignore_status=True): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
libvirt_vmxml.check_guest_xml_by_xpaths
has only two params , Does the ignore_status=True
work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
avocado-framework/avocado-vt#3716 added new param
import json | ||
import os | ||
import re |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
json should be the last in this order
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the reason?
Depend on
Case ID: xxx-296727
Signed-off-by: Dan Zheng [email protected]