Add --inst-all and --rm-all options to generator #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These speed up the migration to/from autometrics for bigger, established codebases. Fixes #72
mellowagain
approved these changes
Oct 19, 2023
cmd/autometrics/main.go
Outdated
| @@ -24,6 +24,8 @@ type args struct { | |||
| UseOtel bool `arg:"--otel" default:"false" help:"Use OpenTelemetry client library to instrument code instead of default Prometheus."` | |||
| AllowCustomLatencies bool `arg:"--custom-latency" default:"false" help:"Allow non-default latencies to be used in latency-based SLOs."` | |||
| DisableDocGeneration bool `arg:"--no-doc,env:AM_NO_DOCGEN" default:"false" help:"Disable documentation links generation for all instrumented functions. Has the same effect as --no-doc in the //autometrics:inst directive."` | |||
| ProcessAllFunctions bool `arg:"--inst-all,env:AM_INST_ALL" default:"false" help:"Instrument all function declared in the file to transform. Overwritten by the --rm-all argument if both are set."` | |||
There was a problem hiding this comment.
can we have an alias for this named --install-all? i know this is cool af but i see the potential for confusing typos
There was a problem hiding this comment.
I'll change the argument name sure, I didn't see the inst-all / install bit :D
There was a problem hiding this comment.
no dont change it its funny, just add an alias :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These speed up the migration to/from autometrics for bigger, established codebases.
Fixes #72
Checklist