This repository has been archived by the owner on Feb 14, 2018. It is now read-only.
rfc6750 compability #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hardymansen: I think this PR looks good. |
|
Sure, will have a stab at it. |
|
Added a scope=admin to the default proxy and added the WWW-Authenticate to the test cases, and a new test case for scope missing specific. Verified and fixed a 200 test. Now all 12 tests pass |
|
@twistedstream any update on this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Saw #43
Support for the WWW-Authenticate response header, according to https://tools.ietf.org/html/rfc6750#section-3.1
For my user case, i need also specific implementation for scope as will be using in OAuth 2.0 framework.
e.g returning a 403, and the scopes required.
Not sure if you are liking that if , or if you want the lib to be more generic.