CANCUN hard fork impelemtation #39

mrLSD · 2024-03-29T08:08:00Z

Description

📚 Deneb/Cancun Ethereum specification: https://eips.ethereum.org/EIPS/eip-7569

This PR includes implementation:
➡️ EIP-1153: Transient storage opcodes
➡️ EIP-4844: Shard Blob Transactions
➡️ EIP-5656: MCOPY - Memory copying instruction
➡️ EIP-6780: SELFDESTRUCT only in same transaction
➡️ EIP-7516: BLOBBASEFEE opcode

Improvements

➡️ Refactored evm-tests to 100% of ethereum-jsob-tests pass for:

Shanghai hardfork
Cancun hardfork

➡️ Fixed bugs in evm-tests
➡️ Fixed bugs in evm

Incudes

Feat: refactore evm-tests #40 Feat: refactore evm-tests
Fix: tests for EIP-3860 #41 Fix: tests for EIP-3860
Feat: refactore EIP-4844 #42 Feat: refactore EIP-4844

…d-fork/cancun

…functions for CANCUN hardfork

…cked for blob_gasprice

core/src/memory.rs

…ucts

birchmd · 2024-04-09T14:15:23Z

core/src/utils.rs

+///
+/// This function panics if `denominator` is zero.
+#[inline]
+pub fn fake_exponential(factor: u64, numerator: u64, denominator: u64) -> u128 {


I worry about overflow in this function.

The implementation in the EIP is written in Python which uses arbitrary precision integers. The geth implementation uses arbitrary precision integers as well.

The Erigon implementation uses 256-bit integers, but still checks for overflow and returns an error in that case. I think we should follow this example and also use U256 with overflow-checked arithmetic.

The source is here.

But I agree, it seems like should be refactored.

Actually... this function can be removed. As it's for test KZG-precompiles

Sure if it's not needed then please remove.

Done: 12b1dd0

src/executor/stack/memory.rs

runtime/src/eval/system.rs

src/executor/stack/executor.rs

runtime/src/handler.rs

src/executor/stack/memory.rs

core/src/utils.rs

src/executor/stack/memory.rs

* Extend tests output and refactore tests runner * Refactored CLI for recursive tests and extended information * Set Shanghai spec as default * Extend output for tests * evm-tests: extend state statistics for failed results * evm-tests: extended debug info * Extend gas cost analyzer * Extend tests and fixes for Cancun hard fork * Fix: Apply CREATE storage reset - changed logic. GAS cost for MCOPY - improved calculation * EIP-3607 implementation. DeepCall bug fixes. KZG-boilerplate * KZG precompile * Removev debug info * Fix: tests for EIP-3860 (#41) undefined * ForkSpec string error. Refactored usage as constantn USIZE_MAX * Remove already fixed tests from skipping list * Added KzgInput

* Extend tests output and refactore tests runner * Refactored CLI for recursive tests and extended information * Set Shanghai spec as default * Extend output for tests * evm-tests: extend state statistics for failed results * evm-tests: extended debug info * Extend gas cost analyzer * Extend tests and fixes for Cancun hard fork * Fix: Apply CREATE storage reset - changed logic. GAS cost for MCOPY - improved calculation * EIP-3607 implementation. DeepCall bug fixes. KZG-boilerplate * KZG precompile * EIP-3860 test flow fixes * Fix Shanghai tests * Removev debug info * Separate check_exit_reason func * Remove printing * Added `as_deref` to check_create_exit_reason * Fix: tests for EIP-3860 (#41) undefined * ForkSpec string error. Refactored usage as constantn USIZE_MAX * Remove already fixed tests from skipping list * Refactore blob-hash logic and tests * Added KzgInput * Gas price fix and investigations for blob-transactions * Refactored skipped-match and clippy * Refactored gas price and should-skip logic * Fix tests for KZG-precompiles and SSTORE gas cost * Added print-debug feature * Fix randomness validation * Refactore transactions validation * Extend expected check for call-transaction and empty-create assertion * Edit doc comments

birchmd

Thanks for all your work on this large feature!

birchmd · 2024-06-05T12:25:00Z

core/src/utils.rs

+///
+/// This function panics if `denominator` is zero.
+#[inline]
+pub fn fake_exponential(factor: u64, numerator: u64, denominator: u64) -> u128 {


Sure if it's not needed then please remove.

aleksuss

Overall looks good 👍🏻

core/src/memory.rs

evm-tests/ethjson/src/spec/builtin.rs

evm-tests/jsontests/src/main.rs

src/backend/memory.rs

## Description ➡️ Added **EVM CANCUN** hard fork support. Based on SputnikVM release [v0.42.0-aurora](https://github.com/aurora-is-near/sputnikvm/releases/tag/v0.42.0-aurora) ➡️ Changed `engine-tests` that related to **CACUN** changes ➡️ Solidity: updated to `0.8.25` which support **CANCUN** Features ➡️ Extended Transactions fields for **CANCUN** hard fork requirements ### Cancun hard fork ➡️ EVM impelentation of Cancun hard fork: aurora-is-near/sputnikvm/pull/39 ### Breaking changes ➡️ Transaction extended according to [EIP-4844](https://eips.ethereum.org/EIPS/eip-4844) requirements ### Gas cost Gas cost changed as expected insignificantly. - 2 tests: gas increased to `1 TGas` - 1 test: gas decreased to `1 TGas`

Added Config and Opcodes

b5cc743

mrLSD self-assigned this Mar 29, 2024

mrLSD added hard-fork enhancement New feature or request labels Mar 29, 2024

mrLSD added 10 commits March 29, 2024 09:48

Added very basic gas for opcodes

57c4d77

Cover all CANCUN opcode gas cost

03d33c8

Merge branch 'master' of github.com:aurora-is-near/sputnikvm into har…

a41fd51

…d-fork/cancun

SELFDESTRUCT implementation. Added basic function for systtem-opcode …

9f61f32

…functions for CANCUN hardfork

BLOBBASEFEE implementation

214aa99

Added evm-core utility function for BLOBBASEFEE and refactored EVM Ba…

5cb066a

…cked for blob_gasprice

MCOPY logic

2bac4ca

MCOPY: improve copying logic and optimize

0679655

BLOBHASH implementation

3c3d5f0

Transient storage implementation

22b8129

mrLSD marked this pull request as ready for review April 5, 2024 11:09

mrLSD mentioned this pull request Apr 8, 2024

Feat: add CANCUN hard fork support aurora-is-near/aurora-engine#926

Merged

birchmd reviewed Apr 8, 2024

View reviewed changes

core/src/memory.rs Show resolved Hide resolved

mrLSD and others added 4 commits April 8, 2024 19:09

Add extra check for func in MCOPY flow. Return old visibility for str…

3fccd83

…ucts

Update ethereum/tests to v13.2

07d9fb7

chore: bump ethtests to v13.2

7e2ef13

Fix all tests that before Cancun hard fork

c99a650

birchmd reviewed Apr 9, 2024

View reviewed changes

birchmd requested changes Apr 9, 2024

View reviewed changes

src/executor/stack/memory.rs Outdated Show resolved Hide resolved

runtime/src/eval/system.rs Outdated Show resolved Hide resolved

src/executor/stack/executor.rs Outdated Show resolved Hide resolved

runtime/src/handler.rs Outdated Show resolved Hide resolved

Refactoring: get_tstorage, Handler and other

2814e2c

aleksuss reviewed Apr 10, 2024

View reviewed changes

src/executor/stack/memory.rs Outdated Show resolved Hide resolved

aleksuss reviewed Apr 10, 2024

View reviewed changes

core/src/utils.rs Outdated Show resolved Hide resolved

aleksuss reviewed Apr 10, 2024

View reviewed changes

core/src/utils.rs Outdated Show resolved Hide resolved

mrLSD mentioned this pull request Apr 10, 2024

Feat: refactore evm-tests #40

Merged

birchmd reviewed Apr 10, 2024

View reviewed changes

src/executor/stack/memory.rs Show resolved Hide resolved

Addedc to exit_commit logic

da568d3

mrLSD mentioned this pull request May 16, 2024

Fix: tests for EIP-3860 #41

Merged

mrLSD mentioned this pull request May 27, 2024

Feat: refactore EIP-4844 #42

Merged

mrLSD added 2 commits May 28, 2024 12:04

mrLSD mentioned this pull request Jun 5, 2024

Feat: refactore CLI tool and CI, tests cleanup #43

Merged

mrLSD requested review from birchmd and aleksuss June 5, 2024 08:50

birchmd previously approved these changes Jun 5, 2024

View reviewed changes

Remove KZG-precompiles specific logic from EVM core/utils

12b1dd0

mrLSD dismissed birchmd’s stale review via 12b1dd0 June 5, 2024 13:30

mrLSD requested a review from birchmd June 5, 2024 13:42

aleksuss previously approved these changes Jun 10, 2024

View reviewed changes

Mispell changes afer review

31e469a

mrLSD dismissed aleksuss’s stale review via 31e469a June 10, 2024 23:58

mrLSD requested a review from aleksuss June 10, 2024 23:58

Copy fun - refactored error message

49f0e3d

aleksuss approved these changes Jun 11, 2024

View reviewed changes

birchmd approved these changes Jun 11, 2024

View reviewed changes

mrLSD merged commit f737dd8 into master Jun 11, 2024
3 checks passed

mrLSD deleted the hard-fork/cancun branch June 11, 2024 16:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CANCUN hard fork impelemtation #39

CANCUN hard fork impelemtation #39

mrLSD commented Mar 29, 2024 •

edited

Loading

birchmd Apr 9, 2024

mrLSD Apr 9, 2024

mrLSD Apr 9, 2024

mrLSD Jun 5, 2024

birchmd Jun 5, 2024

mrLSD Jun 5, 2024

birchmd left a comment

birchmd Jun 5, 2024

aleksuss left a comment

CANCUN hard fork impelemtation #39

CANCUN hard fork impelemtation #39

Conversation

mrLSD commented Mar 29, 2024 • edited Loading

Description

Improvements

Incudes

birchmd Apr 9, 2024

Choose a reason for hiding this comment

mrLSD Apr 9, 2024

Choose a reason for hiding this comment

mrLSD Apr 9, 2024

Choose a reason for hiding this comment

mrLSD Jun 5, 2024

Choose a reason for hiding this comment

birchmd Jun 5, 2024

Choose a reason for hiding this comment

mrLSD Jun 5, 2024

Choose a reason for hiding this comment

birchmd left a comment

Choose a reason for hiding this comment

birchmd Jun 5, 2024

Choose a reason for hiding this comment

aleksuss left a comment

Choose a reason for hiding this comment

mrLSD commented Mar 29, 2024 •

edited

Loading