Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: apply suggestions by clippy #28

Merged
merged 4 commits into from
Sep 12, 2023

Conversation

aleksuss
Copy link
Member

@aleksuss aleksuss commented Sep 5, 2023

The PR applies suggestions by clippy levels all and nursery.

@mrLSD
Copy link
Member

mrLSD commented Sep 5, 2023

This clippy version is too old. I propose switching cliipy to nightly-2023-08-24 and fixing that version.

And then switch back to the current library rust version.

And why it's so old rust version?

src/executor/stack/executor.rs Show resolved Hide resolved
@aleksuss
Copy link
Member Author

aleksuss commented Sep 5, 2023

@birchmd any idea why this test is failed? Should it be fixed?

UPD: With the evm from the upstream this test is passed.

@birchmd
Copy link
Member

birchmd commented Sep 5, 2023

No, I am not sure why that test would be failing. But if it passes on upstream then it is worth looking into.

@aleksuss aleksuss merged commit 84536d5 into v0.38.3-aurora-branch Sep 12, 2023
2 of 3 checks passed
aleksuss added a commit that referenced this pull request Sep 12, 2023
@aleksuss aleksuss deleted the chore/aleksuss/clippy_lints branch September 25, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants