Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: exclude Dataset.prop #87

Merged
merged 1 commit into from
Apr 30, 2024
Merged

DOC: exclude Dataset.prop #87

merged 1 commit into from
Apr 30, 2024

Conversation

hagenw
Copy link
Member

@hagenw hagenw commented Apr 26, 2024

Closes #85

This makes sure the class variable audbcards.Dataset.props is not documented in the API docs, by renaming it to _props.

hagenw added a commit that referenced this pull request Apr 26, 2024
hagenw added a commit that referenced this pull request Apr 30, 2024
* Speed up caching of audbcards.Dataset

* Try to fix

* Another fix

* Improve execution after loading from cache

* Use hidden attributes

* Add audbcards.Dataset.schemes_summary

* Ensure header and deps are loaded on the fly

* Add docstring example

* Readd self.cache_root

* Do not test docstrings of sphinx extension

* Ensure everything is loaded, starting from cache

* Improve code and tests

* Remove doctest

* Re-enable test for same header

* Rename Dataset.properties() to cached_properties()

* Rename cached_properties() to _cached_properties()

* Fix inclusion of properties in API docs

* Revert changes handled in #87

* Include cache_root in API docs

* Improve docstring of repository_object

* Fix docstring of backend

* Remove Artifactory related pragma
Copy link
Member

@ChristianGeng ChristianGeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does what is written in the description - remove loop index that had not been "private" from accidental inclusion in api doc.

The review is pretty unspectacular - I will simply approve.

@hagenw hagenw merged commit d2510ee into main Apr 30, 2024
6 checks passed
@hagenw hagenw deleted the exclude-props branch April 30, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dataset.prop is wrongly included in API documentaton
2 participants