Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip duration plots for single duration #74

Merged
merged 3 commits into from
Apr 3, 2024
Merged

Conversation

hagenw
Copy link
Member

@hagenw hagenw commented Apr 2, 2024

Closes #73

This skips creating a file duration plot, if all files have the same duration and simplifies the resulting string to e.g.

duration distribution: each file is 0.1 s

image

Copy link
Member

@ChristianGeng ChristianGeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature ios useful: it does not make sense to plot a uniform distribution.

There are only minor concerns, most importantly about how intuitive the distribution string is for users.

I have given am approval anyway, as there is fairly little to do before this can be merged.

@hagenw hagenw merged commit fef0b0e into main Apr 3, 2024
6 checks passed
@hagenw hagenw deleted the single-duration-distribution branch April 3, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle datasets with a fixed file duration
2 participants