-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Dataset attributes and methods #69
Conversation
I have implemented setting the cached properties programmatically in 2bf18fd. There is one difference: Now things have crossed: I have boldly committed without having the review request on the radar. |
Doesn't matter, I just assigned you so you get an alert that something is going on here.
Could you try to test this? |
bed2217
to
dbc7cae
Compare
Yes, in dbc7cae |
Co-authored-by: Hagen Wierstorf <[email protected]>
Great, I think we are ready to merge here, or any objections? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This ensures that the API docs will contain the cached properties
that are defined for each dataset.
In addition the code that fetches these props from the private class is teted.
I have written an approval review. Shall I merge or do you want to go for it? |
Closes #66
This ensures that all attributes/methods of
audbcards._Dataset
are also included inaudbcards.Dataset
and are displayed in its API documentation.At the moment this is done by assigning them all manually insideaudbcards.Dataset
, but I haven't found a better way yet.