Continuous integration testing and documentation #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I do not have the admin powers to enable GitHub Actions within the
atlregionalGitHub org. You can see this code running its action and completing the tests successfully in my fork here: https://github.com/driftlesslabs/client_arc_abm/actions/runs/11044504531Someone with the power to turn actions on will need to do so for CI testing to work in this repo.
Also: I identified through this work a minor bug in ActivitySim itself, ActivitySim/activitysim#891. This bug makes it slightly more difficult to run tests on the ARC model, as the single process and multiprocess results end up slightly different. I have forced all the CI testing of the ARC model into a single-process stream for now. Once this bug is corrected, these tests will break (as the random numbers for the trip scheduling choice will change) but it will be easy at that time to (1) regenerate the test targets to accommodate the change, and (2) add MP tests that validate against the same new targets.