Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connection spec v2 #156

Merged
merged 10 commits into from
Jul 10, 2024
Merged

Conversation

YufengXin
Copy link
Collaborator

swagger.yaml absorbing connection request spec v2

@YufengXin YufengXin self-assigned this Jul 3, 2024
@YufengXin YufengXin linked an issue Jul 3, 2024 that may be closed by this pull request
@YufengXin YufengXin marked this pull request as draft July 3, 2024 14:21
@coveralls
Copy link

coveralls commented Jul 3, 2024

Pull Request Test Coverage Report for Build 9780622911

Details

  • 0 of 276 (0.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-13.8%) to 63.84%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sdx_lc/models/connection_qos_unit.py 0 26 0.0%
sdx_lc/models/connection_scheduling.py 0 26 0.0%
sdx_lc/models/connection_qos_metrics.py 0 76 0.0%
sdx_lc/models/connection_v2.py 0 148 0.0%
Totals Coverage Status
Change from base Build 9600447801: -13.8%
Covered Lines: 978
Relevant Lines: 1481

💛 - Coveralls

sajith added a commit to atlanticwave-sdx/sdx-controller that referenced this pull request Jul 3, 2024
See these commits on sdx-lc:

- 128c3445010310a3159c6c1b69e789ac6524d572
- f5a5f576b32d930a34628266d944fb7943057462
- 51f3a5349db2a7d3ed41d54f8d5466116b4bea10
- ab2f6f7df7e591735afd4c388c5a6de238f96ed4
- 22622d1cebb96f263fd8d41a9d27ba9a3479cfbe
- 9c5963a9b9985a95b771b5f3cbeab9053bec8d76

(On branch 152-update-the-schema-on-connection-request-spec, PR:
atlanticwave-sdx/sdx-lc#156)
@sajith
Copy link
Member

sajith commented Jul 3, 2024

Test coverage dropped because of the new model files. But I am not quite certain that we are actually using them.

As far as I have understood, the case for these model files is when doing JSON serialization and deserialization. In controller methods, we are not serializing the request bodies to objects of the model classes, nor are we returning such objects. We're mostly working with regular Python dicts and JSON.

The only exception is perhaps the unit tests in sdx-lc. But I made them that way, before I understood that we can use the static JSON files we now have in datamodel.

sdx_lc/swagger/swagger.yaml Outdated Show resolved Hide resolved
sdx_lc/swagger/swagger.yaml Outdated Show resolved Hide resolved
@YufengXin YufengXin marked this pull request as ready for review July 5, 2024 20:40
@coveralls
Copy link

coveralls commented Jul 8, 2024

Pull Request Test Coverage Report for Build 9877274983

Details

  • 221 of 280 (78.93%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 78.261%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sdx_lc/models/connection_scheduling.py 24 27 88.89%
sdx_lc/models/connection_qos_unit.py 18 27 66.67%
sdx_lc/models/connection_qos_metrics.py 67 77 87.01%
sdx_lc/models/connection_v2.py 112 149 75.17%
Totals Coverage Status
Change from base Build 9600447801: 0.6%
Covered Lines: 1210
Relevant Lines: 1485

💛 - Coveralls

@YufengXin YufengXin merged commit 7abd910 into main Jul 10, 2024
8 checks passed
@YufengXin YufengXin deleted the 152-update-the-schema-on-connection-request-spec branch July 10, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update the schema on connection request spec
4 participants