Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add archived connection api #331

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Add archived connection api #331

merged 2 commits into from
Oct 9, 2024

Conversation

congwang09
Copy link
Contributor

Resolves: #238

This PR adds an API to query archived connections for a specific service ID. It may not make sense to be able to query all archived connections at this point, because there can be plenty of connections, resulting a huge response.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11241646530

Details

  • 4 of 12 (33.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 58.166%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sdx_controller/controllers/l2vpn_controller.py 3 7 42.86%
sdx_controller/handlers/connection_handler.py 1 5 20.0%
Totals Coverage Status
Change from base Build 11184666373: -0.2%
Covered Lines: 1088
Relevant Lines: 1927

💛 - Coveralls

@YufengXin
Copy link
Collaborator

in swagger.yaml, is this necessary for xml?

         application/xml:
          schema:
            $ref: '#/components/schemas/connection'

@congwang09 congwang09 merged commit a0813f1 into main Oct 9, 2024
11 checks passed
@congwang09 congwang09 deleted the add-archived-connection-api branch October 9, 2024 14:43
@congwang09
Copy link
Contributor Author

in swagger.yaml, is this necessary for xml?

         application/xml:
          schema:
            $ref: '#/components/schemas/connection'

Yeah I think this is not needed, it exists for other APIs, for example: /l2vpn/1.0/{service_id} here. I'll create a separate PR to test and clean this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query connection event history
3 participants