Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use connection request v2 spec #297

Merged
merged 17 commits into from
Jul 10, 2024
Merged

Use connection request v2 spec #297

merged 17 commits into from
Jul 10, 2024

Commits on Jul 2, 2024

  1. Use pce branch that implements v2 connection spec

    @sajith
    sajith committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    7a620f4 View commit details
    Browse the repository at this point in the history

  2. Add a test case for v2 connection request

    @sajith
    sajith committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    52b9c93 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. Use connection_v2 definition from sdx-lc 

    See these commits on sdx-lc:

- 128c3445010310a3159c6c1b69e789ac6524d572
- f5a5f576b32d930a34628266d944fb7943057462
- 51f3a5349db2a7d3ed41d54f8d5466116b4bea10
- ab2f6f7df7e591735afd4c388c5a6de238f96ed4
- 22622d1cebb96f263fd8d41a9d27ba9a3479cfbe
- 9c5963a9b9985a95b771b5f3cbeab9053bec8d76

(On branch 152-update-the-schema-on-connection-request-spec, PR:
atlanticwave-sdx/sdx-lc#156)
    @sajith
    sajith committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    925528c View commit details
    Browse the repository at this point in the history

  2. Update expected error message 

    When we use `oneOf` in request body schemas, the error message has
less detail than it previously had.
    @sajith
    sajith committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    67b7d2f View commit details
    Browse the repository at this point in the history

  3. Match port and notifications fields with example connection request

    @sajith
    sajith committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    9f9c987 View commit details
    Browse the repository at this point in the history

  4. Expect non-zero items in response JSON 

    Seems that we get two items in the response now, after adding another
test with a different ID. Probably should investigate this further
later.
    @sajith
    sajith committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    5104455 View commit details
    Browse the repository at this point in the history

  5. Expect error response to the v2 request

    @sajith
    sajith committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    cef6d9e View commit details
    Browse the repository at this point in the history

  6. Connection requests do not carry an ID in v2

    @sajith
    sajith committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    acf011e View commit details
    Browse the repository at this point in the history

  7. Remove ID from v2-format connection request

    @sajith
    sajith committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    37c447d View commit details
    Browse the repository at this point in the history

  8. Generate a connection ID if the request does not have one

    @sajith
    sajith committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    e3f07f3 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2024

  1. Update a comment and add an assertion

    @sajith
    sajith committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    ac9ee20 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. Use pce version that has the v2 request we need

    @sajith
    sajith committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    570c5f5 View commit details
    Browse the repository at this point in the history

  2. Add a test for a v2 connection request that gets solved

    @sajith
    sajith committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    3f630fa View commit details
    Browse the repository at this point in the history

  3. Use the right Amlight topology

    @sajith
    sajith committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    6328f8a View commit details
    Browse the repository at this point in the history

  4. Add more assertions

    @sajith
    sajith committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    016d00b View commit details
    Browse the repository at this point in the history

  5. Update comments

    @sajith
    sajith committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    649cc32 View commit details
    Browse the repository at this point in the history

  6. Bump pce up

    @sajith
    sajith committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    4185b10 View commit details
    Browse the repository at this point in the history