Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use tox-docker expose directive #292

Merged
merged 23 commits into from
Jun 14, 2024
Merged

Use tox-docker expose directive #292

merged 23 commits into from
Jun 14, 2024

Conversation

sajith
Copy link
Member

@sajith sajith commented Jun 14, 2024

Resolves #291 by splitting MONGODB_CONNSTRING to MONGO_HOST, MONGO_PORT, MONGO_USER, and MONGO_PASS.

sajith added 21 commits June 13, 2024 15:55
@sajith
Use expose instead of ports for tox-docker
44a6cb4 
tox-docker 5.0.0 has deprecated `ports`; we need to use `expose`
instead.  This is a good change; with `expose` the services we use
when testing should not conflict with any pre-existing services.

We could have pinned to an older version of tox-docker, but older
tox-docker sometimes errors out if the right version of
requests (<=2.31.0) is not available.

docker/docker-py#3256

A fallout of this change is that we can't use MONGODB_CONNSTRING
anymore, since forming a URI using environment variables from tox
appears to be rather awkward.

tox-dev/tox-docker#187
@sajith
Split MONGODB_CONNSTRING to MONGO_{USER,PASS,HOST,PORT}
8cd34da
@sajith
Print environment variables before running tests
96d0eb5
@sajith
Use the right DB env vars in test
3939a4c
@sajith
Log AMQP URI
d5512d0
@sajith
Log DB URI
651ceb4
@sajith
Update env template
57be985
@sajith
Remove unused MONGODB_DATA_DIR
05af1d3
@sajith
Use the right MONGO variables in compose spec
e5bb6eb
@sajith
Use app settings up
cd5fbdc
@sajith
Move DB variable up
ce66f7c
@sajith
Add MQ_PORT to compose spec
fa2e17e
@sajith
Use some more defaults
f1e8384
@sajith
Avoid quoting defaults
7994984
@sajith
Update env vars in CI
8a99084
@sajith
Hint required versions of tox and tox-docker in README
a133f4d
@sajith
Update instructions about testing with pytest
c2f5012
@sajith
Mention the need for Docker
0ab3c4e
@sajith
Leave a hint about logging
e136ea1
@sajith
Do not expose elasticsearch port outside of compose
9c6b298
@sajith
Connect to elasticsearch service spawned by compose
9ed173e
@coveralls
Copy link

coveralls commented Jun 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9517324062

Details

  • 10 of 12 (83.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 52.459%
Changes Missing Coverage Covered Lines Changed/Added Lines %
sdx_controller/utils/db_utils.py 9 11 81.82%
Totals Coverage Status
Change from base Build 9500593558: 0.1%
Covered Lines: 755
Relevant Lines: 1464
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9517871654

Details

  • 10 of 12 (83.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 52.459%
Changes Missing Coverage Covered Lines Changed/Added Lines %
sdx_controller/utils/db_utils.py 9 11 81.82%
Totals Coverage Status
Change from base Build 9500593558: 0.1%
Covered Lines: 755
Relevant Lines: 1464
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9518020248

Details

  • 10 of 12 (83.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 52.459%
Changes Missing Coverage Covered Lines Changed/Added Lines %
sdx_controller/utils/db_utils.py 9 11 81.82%
Totals Coverage Status
Change from base Build 9500593558: 0.1%
Covered Lines: 755
Relevant Lines: 1464
💛 - Coveralls

@sajith sajith merged commit 2c2cc42 into main Jun 14, 2024
11 checks passed
@sajith sajith deleted the 291.use-tox-expose-directive branch June 14, 2024 15:09
@sajith sajith mentioned this pull request Jun 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YufengXin YufengXin YufengXin approved these changes

@congwang09 congwang09 Awaiting requested review from congwang09

Assignees

@sajith sajith

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tox-docker 5.0.0 has deprecated ports
3 participants
@sajith @coveralls @YufengXin