Make sdx controller a WSGI app #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7715376992
💛 - Coveralls |
With daemon = True, when stopping the process:
^CINFO:root:Stopping RPC queue consumer
INFO:sdx_controller.messaging.rpc_queue_consumer:[MQ] Stopping threads.
When daemon is not set:
^C^CException ignored in: <module 'threading' from '/usr/lib/python3.11/threading.py'>
Traceback (most recent call last):
File "/usr/lib/python3.11/threading.py", line 1583, in _shutdown
lock.acquire()
KeyboardInterrupt:
INFO:root:Stopping RPC queue consumer
INFO:sdx_controller.messaging.rpc_queue_consumer:[MQ] Stopping threads.
This is a work-around with testing in mind. We do not really use the message queue, at least right now, in our little unit/integration test suite. We do use the database. With this restructuring, we do not have to bring up the message queue for testing, just the DB. When we are ready to test things with the message queue, we might want to turn this back though.
WSGI server should manage the threads now
YufengXin
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #135. These commands should work now:
$ flask --app sdx_controller.app [run|routes|shell]The above should work for development purposes. For production, we should be using:
Further,
docker compose upwill runuvicorn sdx_controller.app:app.