-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove top-level tests and test data #183
Conversation
These tests are largely the same as those in PCE. The purpose originally was to let Cong to test the PCE APIs within the SDX-Controller before integrating into the controller code in confidence. So it's Cong's call @congwang09. |
That makes sense as an interim measure. However if we keep the tests here, it is going to duplicate the code that's been already moved to pce (in atlanticwave-sdx/pce#134). That is less than ideal. If we really don't mind duplicating tests, we should still remove the static JSON files from here and use the ones from pce once atlanticwave-sdx/pce#139 is merged. I will update this PR based on Cong's feedback. |
I think this is fine. I'll use the tests in pce for testing. And we can avoid. inconsistency between the two repo. |
Issue is #182. Changes:
tests/test_Solver.py
, because it really is a test of PCE. I will move that test to pce (or at least parts of it that do not overlap with the existing pce tests). The issue to track this is Move some sdx-controller tests here pce#132.samples
directory, because the topology files are broken.Also see #168.