Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Add Dockerfile #175

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jplattel
Copy link

Hi! I wanted camelot to be accessible in a docker container. So I added a Dockerfile that let's you run camelot containerized. Not sure if you want this within you scope, but it might be handy :)

@codecov-io
Copy link

codecov-io commented Oct 25, 2018

Codecov Report

Merging #175 into master will decrease coverage by 3.76%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
- Coverage   87.94%   84.17%   -3.77%     
==========================================
  Files          13       13              
  Lines        1410     1226     -184     
  Branches      333      294      -39     
==========================================
- Hits         1240     1032     -208     
- Misses        114      150      +36     
+ Partials       56       44      -12
Impacted Files Coverage Δ
camelot/plotting.py 16% <0%> (-76.08%) ⬇️
camelot/core.py 87.5% <0%> (-6.16%) ⬇️
camelot/io.py 100% <0%> (ø) ⬆️
camelot/parsers/lattice.py 89.47% <0%> (+0.35%) ⬆️
camelot/handlers.py 83.33% <0%> (+0.83%) ⬆️
camelot/parsers/stream.py 92.52% <0%> (+1.42%) ⬆️
camelot/cli.py 93.68% <0%> (+8.49%) ⬆️
camelot/__version__.py 100% <0%> (+23.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 153869f...8f8860c. Read the comment docs.

@vinayak-mehta
Copy link
Contributor

Thanks for the Dockerfile @jplattel! I might add it master later by creating a separate folder for such files.

@jplattel
Copy link
Author

Awesome, thanks! 👍

@vinayak-mehta vinayak-mehta changed the title added a Dockerfile [MRG] Add Dockerfile Jan 2, 2019
kirbs- pushed a commit to kirbs-/camelot that referenced this pull request Jul 31, 2020
@TheApeMachine
Copy link

Strange I went Dockerfile as well, since there is a lot that needs to be done if you go from the docs alone, but I needed to add:

RUN apt-get update && apt-get install -y ghostscript python3-tk ffmpeg libsm6 libxext6

Because of a libGL error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants