Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed error was not forwarded #36

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AndyOGo
Copy link

@AndyOGo AndyOGo commented Feb 17, 2017

fixes #35

As described in https://github.com/sass/node-sass#importer--v200---experimental

importers can return error and LibSass will emit that error in response. For instance:

done(new Error('doesn\'t exist!'));
// or return synchornously
return new Error('nothing to do here');

@AndyOGo
Copy link
Author

AndyOGo commented Feb 17, 2017

@Snugug @xzyfer
Hey guys.
Does any one of you two has some time check the outstanding PRs?
Or is there no plan to maintain this repo.
To be honest I find it really useful and want to contribute, but if no admin is maintaining this, than it will die...

@AndyOGo
Copy link
Author

AndyOGo commented Feb 17, 2017

@metaskills @JohnAlbin @misscs @codingdesigner @iamcarrico @scottkellum
Does anyone of you guys have admin access to this repo?
I would really like to get some bug fixes out, but it doesn't seem to be maintained anymore.
I really find it very useful, though some bugs are addressed with open PR's, they don't get merged...

@AndyOGo AndyOGo force-pushed the bugfix/import-error-not-forwarded-properly branch from 4139e69 to 96e9e1e Compare February 17, 2017 16:08
@AndyOGo
Copy link
Author

AndyOGo commented Feb 20, 2017

if anyone care we forked this repo and republished it on npm as @axa-ch/node-sass-import-once
https://github.com/axa-ch/node-sass-import-once

@AndyOGo
Copy link
Author

AndyOGo commented Dec 11, 2017

@Snugug
This PR is almost a year old...

@Munter
Copy link

Munter commented Apr 18, 2018

I'm hitting this problem again now and am blocked on it. I'd prefer not to have to create fork

@AndyOGo
Copy link
Author

AndyOGo commented Apr 18, 2018

@Munter
I forked it ages ago...
https://github.com/axa-ch/node-sass-import-once

@toshi-toma
Copy link

I also face this problem. Please merge this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not stop CI build if Could not import error
3 participants