Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not stop CI build if Could not import error #35

Closed
AndyOGo opened this issue Feb 16, 2017 · 2 comments · Fixed by axa-ch/node-sass-import-once#1 · May be fixed by #36
Closed

Does not stop CI build if Could not import error #35

AndyOGo opened this issue Feb 16, 2017 · 2 comments · Fixed by axa-ch/node-sass-import-once#1 · May be fixed by #36

Comments

@AndyOGo
Copy link

AndyOGo commented Feb 16, 2017 •
edited
Loading

I just realised that this does not properly throw or setting proper exit codes with process.exitCode if an import fails. Instead it just logs to the console:

Error: Could not import `module-does-not-exist` from any of the following locations:
  /frontend-lib/src/scss/module-does-not-exist.scss
  /frontend-lib/src/scss/module-does-not-exist.sass
  /frontend-lib/src/scss/_module-does-not-exist.scss
  /frontend-lib/src/scss/_module-does-not-exist.sass
  /frontend-lib/node_modules/@axa-ch/style-guide/scss/module-does-not-exist.scss
  /frontend-lib/node_modules/@axa-ch/style-guide/scss/module-does-not-exist.sass
  /frontend-lib/node_modules/@axa-ch/style-guide/scss/_module-does-not-exist.scss
  /frontend-lib/node_modules/@axa-ch/style-guide/scss/_module-does-not-exist.sass

This false behaivior is caused at the following lines:

Further more the done callback in above code blocks does not use first-error arguments.
@AndyOGo AndyOGo mentioned this issue Feb 16, 2017
Closed
@AndyOGo AndyOGo changed the title Does not stop CI build if module not found error Does not stop CI build if Could not import error Feb 16, 2017
@AndyOGo
Copy link
Author

AndyOGo commented Feb 16, 2017

Error should be passed as described in https://github.com/sass/node-sass#importer--v200---experimental

@AndyOGo AndyOGo mentioned this issue Feb 17, 2017
Open
@AndyOGo
Copy link
Author

AndyOGo commented Feb 17, 2017 •
edited
Loading

@Snugug
Is this repo still maintained?
I have opened a PR

@AndyOGo AndyOGo mentioned this issue Feb 17, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@AndyOGo