Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: acknowledgement for v3 #2013

Merged
merged 6 commits into from
Nov 29, 2023

Conversation

jonaslagoni
Copy link
Member

@jonaslagoni jonaslagoni commented Jul 31, 2023

Description
This PR is to add all who participated in the development of v3 in one way or another - maybe you added your own views on features included in v3, attended meetings, adapted documentation, adapted tooling, i.e. helped in any way to make v3 happen 💪

It will be part of the v3 release blog post in the acknowledgement section: https://v3.asyncapi.com/blog/release-notes-3.0.0#acknowledgements

It would be an impossible task for me to go through all relevant issues, PRs, and meetings to find all of you not to mention for sure miss someone, so I am asking for a bit of help to include your name here.

To get added to the list of users just comment on this PR with a link to where you participated (not ALL times, just a single one) and with what name and link it should be associated with, and that's it 🎉

Initial list

@Fannon, @char0n, @fmvilas, @derberg, @smoya, @damaru-inc, @magicmatatjahu, @jessemenning, @GreenRover, @GeraldLoeffler, @c-pius, @iancooper, @dalelane, @joerg-walter-de, @nictownsend, @lbroudoux, @olamiral, @ivangsa, @buehlefs, @jfallows, @adrianhopebailie, @prdatur, @basickarl, @jjimenezroda, @smarek, @natcl, @whitlockjc, @Souvikns

You have been tagged because you are on the initial list of users added to the acknowledgment section because you participated in the development of v3 in one of the spec issues listed under "Completed" in asyncapi/spec#691. That was the best way I saw to kickstart the list.

I am tagging you here to notify you about it and give you the option to be removed, change the link, or name as you see fit. By default, I am using your GitHub handle and public name 😄

@netlify
Copy link

netlify bot commented Jul 31, 2023

Deploy Preview for shimmering-choux-eb0798 ready!

Name Link
🔨 Latest commit 46a1452
🔍 Latest deploy log https://app.netlify.com/sites/shimmering-choux-eb0798/deploys/65525faf61fc5a000804c2e5
😎 Deploy Preview https://deploy-preview-2013--shimmering-choux-eb0798.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AnimeshKumar923
Copy link
Contributor

AnimeshKumar923 commented Jul 31, 2023

Hey there @jonaslagoni ! 👋

  • I've reviewed several of "docs" PR and also currently working on some automation issues
  • I'm adding my recent one here Though it may have been small fixes and errors, but gave my best as per my current level of knowledge. Thank you! 🙇

Name - Animesh Kumar
GitHub - https://www.github.com/animeshkumar923
Twitter/(X?) - https://www.twitter.com/animeshkumar923

@Amzani
Copy link
Contributor

Amzani commented Jul 31, 2023

@jonaslagoni

  • Adding V3 support to studio
  • Reviewed some PRs

Samir AMZANI / https://github.com/Amzani

@derberg
Copy link
Member

derberg commented Aug 1, 2023

@alequetzalli I bet you know all the docs contributors that should be mentioned in the thank you, please share them in a comment.

@smoya
Copy link
Member

smoya commented Aug 1, 2023

I made this slide for my last talk at EDA Summit where I added all the GH avatars of people I considered contributors. I remember I did search across the whole asyncapi GH org by words like v3, etc.
Just in case someone recognises some avatars and want to add the users to the list.

Google Chrome_eWew5MOC

@fmvilas fmvilas requested a review from derberg October 10, 2023 10:32
@derberg
Copy link
Member

derberg commented Oct 11, 2023

@jonaslagoni I see @fmvilas requested review from me, but it is your PR, so please have a look at last comment from @smoya

in general what is your strategy with this one? merge as quick as possible, or keep it open until the end, in case more names pop up?

@alequetzalli pingy pongy regarding #2013 (comment)

@jonaslagoni
Copy link
Member Author

in general what is your strategy with this one? merge as quick as possible, or keep it open until the end, in case more names pop up?

@derberg we can keep it open sure, right up until the release.

@quetzalliwrites
Copy link
Member

@alequetzalli I bet you know all the docs contributors that should be mentioned in the thank you, please share them in a comment.

Hey @derberg, thank you for pointing this out!

To answer your question... I guess it would be all writers working in our Mentorship/GSOD 2023 programs, since they are all writing with only v3 in mind.

The following folks should be added then:

@derberg
Copy link
Member

derberg commented Oct 31, 2023

@alequetzalli no there were no specific updated to Generator docs that Florence had to work on

@jonaslagoni
Copy link
Member Author

Thanks @alequetzalli!

You have been added to the list, please feel free to suggest the name that should be displayed and the link 🙂

@Shurtu-gal
Copy link
Contributor

@jonaslagoni

Ashish Padhy / https://github.com/Shurtu-gal

@derberg
Copy link
Member

derberg commented Nov 13, 2023

please add @alaminthespecial for work on #2004

@jonaslagoni
Copy link
Member Author

@Shurtu-gal and @alaminthespecial you have both been added, feel free to suggest changes to the social links 🙂

@fmvilas fmvilas mentioned this pull request Nov 24, 2023
13 tasks
@derberg
Copy link
Member

derberg commented Nov 28, 2023

I think we can merge this PR as release in next week. If any new name pops up, we can always add it last minute or even after release

@jonaslagoni
Copy link
Member Author

Makes sense 👍

Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@jonaslagoni
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit cad95b9 into asyncapi:next-major-spec Nov 29, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants