Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add Amzani as a code owner #827

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

Amzani
Copy link
Collaborator

@Amzani Amzani commented Oct 25, 2023

Hey Folks, I humbly suggest @Amzani as a code owner of this repo to support the new studio roadmap and mentor current contributors.

Some contributions

If you notice something is still missing please feel free to give open an feedback

@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2023

⚠️ No Changeset found

Latest commit: 9113968

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Oct 25, 2023

Deploy Preview for asyncapi-studio-design-system ready!

Name Link
🔨 Latest commit 9113968
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-studio-design-system/deploys/65437ae63bfedf0008b622b9
😎 Deploy Preview https://deploy-preview-827--asyncapi-studio-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 25, 2023

Deploy Preview for modest-rosalind-098b67 ready!

Name Link
🔨 Latest commit 9113968
🔍 Latest deploy log https://app.netlify.com/sites/modest-rosalind-098b67/deploys/65437ae7c1f2fa0008e5966b
😎 Deploy Preview https://deploy-preview-827--modest-rosalind-098b67.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@KhudaDad414 KhudaDad414 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A big YES from me. 😃

Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! We need more maintainers which doesn't necessarily means we need more code contributions. Yours are really valuable contributions so it's a big YES from me too.

That said, let's leave this open for a few more days in case the rest of the code owners want to chime in.

Copy link
Member

@mcturco mcturco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES! 🚀

Copy link

sonarcloud bot commented Nov 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@fmvilas
Copy link
Member

fmvilas commented Nov 2, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 9fb615e into asyncapi:master Nov 2, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants