Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:speaker images #402

Closed
wants to merge 2 commits into from
Closed

Conversation

NamanSriva
Copy link

@NamanSriva NamanSriva commented Oct 1, 2024

fix: This PR saves the speakers images locally in img folder and instead of fetching image from an URL the images are fetched locally from img folder.
Changed the image paths in Speaker.json file.

Screenshot (95)

Related issue(s)
Fixes #396

Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for peaceful-ramanujan-288045 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 713d6e2
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/66fc055406886c00096f7734
😎 Deploy Preview https://deploy-preview-402--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Oct 1, 2024

We require all PRs to follow Conventional Commits specification.
More details 👇🏼

 No release type found in pull request title "fix:speaker images". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@NamanSriva NamanSriva closed this Oct 1, 2024
@NamanSriva NamanSriva deleted the fix/speaker-images branch October 1, 2024 14:27
@NamanSriva NamanSriva restored the fix/speaker-images branch October 1, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make all speakers images available locally
2 participants