Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added prettier and formatted the files #332

Closed
wants to merge 8 commits into from

Conversation

ashmit-coder
Copy link
Contributor

Description

  • Added prettier to make code maintainable and formatted the existing files.
    Related issue(s)

Resolves: #331

Copy link

netlify bot commented Jun 10, 2024

Deploy Preview for peaceful-ramanujan-288045 ready!

Name Link
🔨 Latest commit 0a1efc7
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/668bddbfe2771300089b7d76
😎 Deploy Preview https://deploy-preview-332--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ashmit-coder
Copy link
Contributor Author

Hey @thulieblack @AceTheCreator if these changes look good I will add the github workflow as well!

@AceTheCreator
Copy link
Member

@ashmit-coder, all of these changes are made by the prettier script, right?

@ashmit-coder
Copy link
Contributor Author

@ashmit-coder, all of these changes are made by the prettier script, right?

yes, in addition to adding the command for prettier in the package.json

@ashmit-coder
Copy link
Contributor Author

Hey @AceTheCreator do take a look I have added the workflow as well. :)

AceTheCreator

This comment was marked as off-topic.

@AceTheCreator
Copy link
Member

Hey @AceTheCreator do take a look I have added the workflow as well. :)

I checked the file, and it looks pretty good. Did you test it?

@ashmit-coder
Copy link
Contributor Author

Hey @AceTheCreator do take a look I have added the workflow as well. :)

I checked the file, and it looks pretty good. Did you test it?

Yeah I did test it with act

@AceTheCreator
Copy link
Member

@ashmit-coder can you please resolve the conflict in this pr ?

@ashmit-coder
Copy link
Contributor Author

@AceTheCreator done

@ashmit-coder
Copy link
Contributor Author

/ptal

@asyncapi-bot
Copy link
Contributor

@thulieblack @Mayaleeeee Please take a look at this PR. Thanks! 👋

@AceTheCreator
Copy link
Member

@ashmit-coder sorry i missed your reminder, can you resolve the current conflict too 🙏🏾

@ashmit-coder
Copy link
Contributor Author

Hey @AceTheCreator done

@AceTheCreator
Copy link
Member

Hey @AceTheCreator done

I noticed in your changes that it seems prettier ran on the .github directory too. should we allow such?

@ashmit-coder
Copy link
Contributor Author

Hey @AceTheCreator done

I noticed in your changes that it seems prettier ran on the .github directory too. should we allow such?

I mean thats your call, but i guess newly added scripts should also be formatted. If you want I will revert those changes and limit it to not enter .github

@AceTheCreator
Copy link
Member

Hey @AceTheCreator done

I noticed in your changes that it seems prettier ran on the .github directory too. should we allow such?

I mean thats your call, but i guess newly added scripts should also be formatted. If you want I will revert those changes and limit it to not enter .github

I guess you're right in terms of new scripts.

@AnimeshKumar923
Copy link

AnimeshKumar923 commented Jul 8, 2024

Hi @ashmit-coder @AceTheCreator 👋

I noticed that the .github directory is also being affected by it. It is centrally managed from https://github.com/asyncapi/.github
Whenever there is a change in the central repository, the whole .github file is pulled and replicated across every repository under AsyncAPI. When that happens it would revert these changes because there is no prettier formatting in that repository.

It may become a hassle in the future with repeated formatting whenever a someone uses the prettier extension and may create confusion.

I would suggest to exclude the .github repo from the prettier linting.

@ashmit-coder
Copy link
Contributor Author

Hey @AceTheCreator I will close this Pr and add prettier to the Next Lint PR Cause version control is giving a lot of issues while changing the .github folder

@ashmit-coder
Copy link
Contributor Author

@AnimeshKumar923 your views will be really helpfull here
#307

@AnimeshKumar923
Copy link

@AnimeshKumar923 your views will be really helpfull here #307

I'll take a look at it. @ashmit-coder 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add prettier to the code base
4 participants