Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: footer section responsiveness #273

Merged
merged 3 commits into from
Mar 12, 2024

Conversation

shauryag2002
Copy link
Contributor

fixes #268

Description

  • Fixes the responsiveness of footer section in mobile

Video of changes:

AsyncApi-fix-footer-responsiveness.mp4

fixes responsiveness of footer section in mobile
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link

netlify bot commented Mar 12, 2024

Deploy Preview for peaceful-ramanujan-288045 ready!

Name Link
🔨 Latest commit a8fe96a
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/65f09e09a23df6000811a647
😎 Deploy Preview https://deploy-preview-273--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shauryag2002 shauryag2002 changed the title fix: Footer section responsiveness fix: footer section responsiveness Mar 12, 2024
@AceTheCreator
Copy link
Member

@shauryag2002 Thanks for your contribution. Just a few suggested changes:

  • On a smaller screen, you should make the footer section direction a column
  • Make the code of conduct link readable

@RamGoel
Copy link
Contributor

RamGoel commented Mar 12, 2024

image
@shauryag2002 You can try making it align like this on mobile devices.

@RamGoel
Copy link
Contributor

RamGoel commented Mar 12, 2024

Looks good now, thanks @shauryag2002. @AceTheCreator you can give it a final look and merge

@AceTheCreator
Copy link
Member

LGTM!!!

@AceTheCreator AceTheCreator merged commit 71da2c4 into asyncapi:master Mar 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Footer Section not aligned
3 participants