Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: past editions module #260

Closed
wants to merge 8 commits into from
Closed

Conversation

RamGoel
Copy link
Contributor

@RamGoel RamGoel commented Jan 24, 2024

Description

This PR implements the past editions module for 2023 edition of conference.(as of now)

Whatever the events get added to cities-list.json. It will automatically create pages out of it.

  • Automatic & manual scroll in speakers slider
  • returns 404 if the year is not in archive. (e.g., 2022)
  • Year wise title for pages (Image attached)
  • Removed agenda as it might not be relevant for past editions.
bandicam-2024-01-24-21-23-51-937_SoiQyhH9.mp4
image

Related Issues

Fixes some part of #259

Copy link

netlify bot commented Jan 24, 2024

Deploy Preview for peaceful-ramanujan-288045 ready!

Name Link
🔨 Latest commit 42f776a
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/65e8d3e9a4bfec000825c0de
😎 Deploy Preview https://deploy-preview-260--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@RamGoel
Copy link
Contributor Author

RamGoel commented Jan 24, 2024

The venue card was wrapped inside Link which was redirecting the recorded talk button to redirect also on the venue link. Moved that link to cover the image area only, so we can place multiple links on card.

@thulieblack
Copy link
Member

This is coming together nicely. @Mayaleeeee @AceTheCreator thoughts on the Past Editions Page?

@Mayaleeeee
Copy link
Member

This is coming together nicely. @Mayaleeeee @AceTheCreator thoughts on the Past Editions Page?

Thank you for mentioning me, @thulieblack. And @RamGoel, I appreciate the work you've done on this issue.

Regarding issue #211, @Thehussayn has already created a low-fidelity design that relates somewhat to this issue. I'll review it soon and see how we can incorporate both designs.

@RamGoel, we'll remove the pagination dots under the " Speaker's " section from the design above and replace them with "View All Speakers." However, we'll keep the animation intact.

Also, please change 'Past editions' to 'Past Editions' and replace 2023 with AACoT'23 in the dropdown.

Finally, I will re-review the design and the #211 issue to figure out how to make it work.

@thulieblack
Copy link
Member

ah I see, alright @Mayaleeeee, kindly review the #211 PR, and @RamGoel you can also have a look at the proposed design and see if you can incorporate them or improve from what we have

@RamGoel
Copy link
Contributor Author

RamGoel commented Jan 30, 2024

Hi both of you, a lil busy these days at work. will possibly try to fix them by next week.

@Mayaleeeee
Copy link
Member

Hi both of you, a lil busy these days at work. will possibly try to fix them by next week.

Hi @RamGoel
Is there any update on this?

@RamGoel
Copy link
Contributor Author

RamGoel commented Feb 23, 2024

Hi both of you, a lil busy these days at work. will possibly try to fix them by next week.

Hi @RamGoel Is there any update on this?

Hi @Mayaleeeee Just give me time of today. I'll push the requested changes.

@RamGoel
Copy link
Contributor Author

RamGoel commented Feb 23, 2024

Hi @Mayaleeeee A new page will open of click of View All Speakers or will show the complete list in that section only.

@RamGoel
Copy link
Contributor Author

RamGoel commented Feb 26, 2024

Hi @Mayaleeeee can you help with this?

@Mayaleeeee
Copy link
Member

Mayaleeeee commented Feb 27, 2024

Hi @Mayaleeeee can you help with this?

I'll definitky take a look at when once I'm on my desktop 🙏

@RamGoel
Copy link
Contributor Author

RamGoel commented Mar 3, 2024

Hi @Mayaleeeee , are you back on desk?

@Mayaleeeee
Copy link
Member

This is coming together nicely. @Mayaleeeee @AceTheCreator thoughts on the Past Editions Page?

Thank you for mentioning me, @thulieblack. And @RamGoel, I appreciate the work you've done on this issue.

Regarding issue #211, @Thehussayn has already created a low-fidelity design that relates somewhat to this issue. I'll review it soon and see how we can incorporate both designs.

@RamGoel, we'll remove the pagination dots under the " Speaker's " section from the design above and replace them with "View All Speakers." However, we'll keep the animation intact.

Also, please change 'Past editions' to 'Past Editions' and replace 2023 with AACoT'23 in the dropdown.

Finally, I will re-review the design and the #211 issue to figure out how to make it work.

Thanks @RamGoel. I have reviewed it, but you still need to make the changes we discussed here.

@Mayaleeeee
Copy link
Member

Mayaleeeee commented Mar 6, 2024

Hi @Mayaleeeee , are you back on desk?

Or is there a new update you'd like me to check?

@RamGoel
Copy link
Contributor Author

RamGoel commented Mar 6, 2024

Hi @Mayaleeeee A new page will open of click of View All Speakers or will show the complete list in that section only.

I wanted your opinion on this.

@Mayaleeeee
Copy link
Member

Hi @Mayaleeeee A new page will open of click of View All Speakers or will show the complete list in that section only.

I wanted your opinion on this.

Oh, great! Let's have a new page when users click on 'View All Speakers' for the 2023 conference.

@RamGoel
Copy link
Contributor Author

RamGoel commented Mar 6, 2024

@Mayaleeeee I have implemented the new page for speakers inside the editions route, url goes like this /editions/[year]/speakers.

The design of the editions page also has been updated after merging changes that @AceTheCreator made in #263 . You can check this for latest preview

@thulieblack
Copy link
Member

Sorry for jumping in late to the discussion.

But this won't be necessary anymore, @RamGoel, since all the conference pages are archived.

What you can work on now is to create a new page on the current website, "Past Editions," and add the previous conference websites.

here are the links to each:

  1. 2023 - https://conference.2023.asyncapi.com/
  2. 2022 - https://conference.2022.asyncapi.com/
  3. 2021 - https://conference.2021.asyncapi.com/
  4. 2020 - https://conference.2020.asyncapi.com/

@RamGoel
Copy link
Contributor Author

RamGoel commented Mar 7, 2024

Okay @thulieblack , got your point. Would you like me to add a dropdown on past editions for all years or cards for all years on a new page?

@thulieblack
Copy link
Member

Cards seem interesting. Lets see what you come up with 😉

@Mayaleeeee
Copy link
Member

Cards seem interesting. Lets see what you come up with 😉

I agree as well. Let's see how it turns out.

@RamGoel
Copy link
Contributor Author

RamGoel commented Mar 8, 2024

@thulieblack @Mayaleeeee raised a new PR #265

@RamGoel RamGoel closed this Mar 8, 2024
@RamGoel RamGoel deleted the feat/2024 branch March 8, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants