Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Add a dag_only parameter #64

Closed
gasci opened this issue Jun 6, 2024 · 6 comments
Closed

Proposal: Add a dag_only parameter #64

gasci opened this issue Jun 6, 2024 · 6 comments

Comments

@gasci
Copy link

gasci commented Jun 6, 2024

We would like to overwrite the dag_only detection on demand. Therefore, it would be great to have a dag_only parameter.

We want to run the deploy action with the dag_only option even though we change files at a non-dags folder. Currently, we are not able to prevent the full environment build image upload.

@sunkickr
Copy link
Contributor

good idea

@gasci
Copy link
Author

gasci commented Jun 26, 2024

Thank you for the feedback. And is it possible to release a v5 after these additions? We are using this action every day and we depend on this feature to make our CI/CD pipelines more flexible.

@gasci
Copy link
Author

gasci commented Sep 3, 2024

Has there been any update on this feature? This feature is really crucial for our pipelines not to push the same image multiple times.

@neel-astro
Copy link
Collaborator

This is resolved as part of adding dbt deploy support in deploy-action, as we introduced a new deploy-type field, that allows users to configure a dags-only deploy if the trigger event only had file changes in the dags folder.
Reference PR that solves the issue: #74

@gasci
Copy link
Author

gasci commented Sep 26, 2024

Does it forcefully dag-only deploy even though the file changes say otherwise?

@neel-astro
Copy link
Collaborator

neel-astro commented Sep 26, 2024

yeah, so if the deploy-action is configured with deploy-type set as dags-only then it will have the following behavior:

  • When a file is updated inside the dags folder - deploy-action would do a dag-only deploy
  • When a non-dag file (i.e. file outside the dags folder) is updated - deploy-action will skip any form of deploy since it is configured for dag-only deploy, and in this case, there are no updates in the dags folder

Note that the change has not yet been released, so you can't use it right away, but trying to get it out soon

@gasci gasci closed this as completed Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants