-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change test_behavior
and execution_mode
to use Enum
as opposed to Literals
#379
Conversation
👷 Deploy Preview for amazing-pothos-a3bca0 processing.
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #379 +/- ##
==========================================
+ Coverage 90.70% 90.98% +0.28%
==========================================
Files 44 45 +1
Lines 1484 1542 +58
==========================================
+ Hits 1346 1403 +57
- Misses 138 139 +1
☔ View full report in Codecov by Sentry. |
only comment here is to see if we can convert strings to enums in/before the converter so this isn't a breaking change. all current code looks good though! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pre-emptively approving once the comment about converting strings to enums is addressed
Thanks, @jlaneve , I'll address it! |
Change
DbtDag
andDbtTaskGroup
so they useEnum
as opposed toLiteral
strings to represent the arguments:test_behavior
execution_mode
This is a breaking change. Before:
Now:
Closes #371