Bugfix: Update doorkeeper to use before_action #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bug at asm-helpful#344 The existing code uses `doorkeeper_for :all, except: [ :create ]` This will cause the following error ``` [1563] - Worker 0 (pid: 1571) booted, phase: 0 12:53:24 worker.1 | `doorkeeper_for` no longer available 12:53:24 worker.1 | 12:53:24 worker.1 | Starting in version 2.0.0 of doorkeeper gem, `doorkeeper_for` is no longer 12:53:24 worker.1 | available. Please change `doorkeeper_for` calls in your application with: 12:53:24 worker.1 | 12:53:24 worker.1 | before_action :doorkeeper_authorize! 12:53:24 worker.1 | 12:53:24 worker.1 | For more information check the README: 12:53:24 worker.1 | https://github.com/doorkeeper-gem/doorkeeper#protecting-resources-with-oauth-aka-your-api-endpoint 12:53:24 worker.1 | 12:53:24 worker.1 | exited with code 1 ``` Further details here https://github.com/doorkeeper-gem/doorkeeper#protecting-resources-with-oauth-aka-your-api-endpoint
|
@hanxue can you take a look at the failing test here and see what's causing it to not pass? |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details of bug at #344
The existing code uses
doorkeeper_for :all, except: [ :create ]This will cause the following error
Further details here
https://github.com/doorkeeper-gem/doorkeeper#protecting-resources-with-oauth-aka-your-api-endpoint