Skip to content

Commit

Permalink
Some changes to the configurations for the new visibility timeout ext…
Browse files Browse the repository at this point in the history
…ension feature. Increase the maximum default to 2 hours, increase the maximum configurable extension to 24 hours, and rename to use the work "maximum" to remain consistent (e.g. maximum_messages). (opensearch-project#3604)

Signed-off-by: David Venable <[email protected]>
  • Loading branch information
dlvenable authored Nov 8, 2023
1 parent 541a2a7 commit 803671a
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public class SqsOptions {
private static final int DEFAULT_MAXIMUM_MESSAGES = 10;
private static final Boolean DEFAULT_VISIBILITY_DUPLICATE_PROTECTION = false;
private static final Duration DEFAULT_VISIBILITY_TIMEOUT_SECONDS = Duration.ofSeconds(30);
private static final Duration DEFAULT_MAX_VISIBILITY_TIMEOUT_EXTENSION = Duration.ofSeconds(1800); // 30 minutes
private static final Duration DEFAULT_MAX_VISIBILITY_TIMEOUT_EXTENSION = Duration.ofHours(2);
private static final Duration DEFAULT_WAIT_TIME_SECONDS = Duration.ofSeconds(20);
private static final Duration DEFAULT_POLL_DELAY_SECONDS = Duration.ofSeconds(0);

Expand All @@ -39,9 +39,9 @@ public class SqsOptions {
@JsonProperty("visibility_duplication_protection")
private Boolean visibilityDuplicateProtection = DEFAULT_VISIBILITY_DUPLICATE_PROTECTION;

@JsonProperty("max_visibility_timeout_extension")
@JsonProperty("maximum_visibility_timeout_extension")
@DurationMin(seconds = 30)
@DurationMax(seconds = 3600)
@DurationMax(hours = 24)
private Duration maxVisibilityTimeoutExtension = DEFAULT_MAX_VISIBILITY_TIMEOUT_EXTENSION;

@JsonProperty("wait_time")
Expand Down

0 comments on commit 803671a

Please sign in to comment.