Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock Maven version #214

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Conversation

abelsromero
Copy link
Member

@abelsromero abelsromero commented Jul 31, 2023

This PR was motivated by multiple PR failing to run tests, not being reproducible locally, and not having information to troubleshoot.

  • Use 's4u/setup-maven-action' to lock Maven version to latest
  • Add the upload of test outputs (compilation, reports, etc.)

@abelsromero
Copy link
Member Author

abelsromero commented Jul 31, 2023

Seems the errors in CI were caused by cache corruption. Clearing the caches worked fine in my form and in CI here.

Still, the PR is a nice addition imho.

@abelsromero
Copy link
Member Author

Still having issues with the download-maven-plugin cache after a second run. I'll go back to my fork in the meantime until a fully validated solution is done to avoid notifications to others.

@abelsromero abelsromero marked this pull request as draft August 1, 2023 07:30
@abelsromero
Copy link
Member Author

Confirmed the issue it's in maven-download-plugin maven-download-plugin/maven-download-plugin#253 👉 reverting it v1.6.9

@abelsromero abelsromero force-pushed the lock-maven-version branch 2 times, most recently from 0c460aa to f3d8a2c Compare August 1, 2023 19:42
@abelsromero abelsromero marked this pull request as ready for review August 1, 2023 19:43
@abelsromero abelsromero merged commit 136b2d1 into asciidoctor:main Aug 1, 2023
6 checks passed
@abelsromero abelsromero deleted the lock-maven-version branch February 4, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant