Replace cgi.parse_header() with custom function for Python 3.13 compat #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With this, one test fails even with Python 3.12. |
The cgi module has been deprecated since Python 3.11 and got removed in Python 3.13. Replace the cgi.parse_header() function with a custom one, as recommended by the Python documentation. Closes arskom#712
t-8ch
force-pushed
the
cgi/parse_header
branch
from
d4a0c49
to
71b7f8d
Compare
|
@bgermann Please try again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cgi module has been deprecated since Python 3.11 and got removed in Python 3.13. Replace the cgi.parse_header() function with a custom one, as recommended by the Python documentation.
Closes #712
Note: There is another usage of
cgiinspyne/server/twisted/http.py, but I have no idea how twisted works, and it's not part of my usecase.@bgermann Could you give this a try in the Debian packaging?