Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add SESSION_DOMAIN env var #48

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

asetty
Copy link
Contributor

@asetty asetty commented Oct 15, 2020

Allow the user to customize the Domain attribute for user
session / cookie.

By default the value is "" and will default to the URL used by the
oidc provider when making the request to the callback.

Signed-off-by: Adam Setters [email protected]

Allow the user to customize the Domain attribute for user
session / cookie.

By default the value is "" and will default to the URL used by the
oidc provider when making the request to the callback.

Signed-off-by: Adam Setters <[email protected]>
@asetty
Copy link
Contributor Author

asetty commented Oct 19, 2020

@yanniszark could you take a look at this?

Also heads up, I'll be sending a PR to add functionality to include the scheme and host for the origURL state sometime this week.

@yanniszark
Copy link
Contributor

yanniszark commented Oct 21, 2020

@asetty thanks for the PR and sorry for the wait.
I'm rather busy with Kubecon these days.
I would feel much more comfortable approving changes if we had an issue outlining what the general plan is. This PR seems like it's part of a bigger plan.
Can you summarize the current state, the problem and the proposed solution in #43?
Please help me see the bigger picture :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants