Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make this library build against more recent arkworks versions #9

Closed
wants to merge 6 commits into from

Conversation

ValarDragon
Copy link
Member

Description

I'm using this for a side project rn, had to update the repo to build with the more recent libraries. I thought I'd PR it in case others would benefit from it.

(Also has the nice side affect of no longer needing any crates patching)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@Pratyush
Copy link
Member

Thanks! Re: the failure wrt ark-sponge, the latter now lives in ark-crypto-primitives

@ValarDragon
Copy link
Member Author

ah yeah, I was only testing with default feature flags, will fix those now!

@ValarDragon
Copy link
Member Author

hrmm, will have to investigate this no-std issue later

@z-tech z-tech closed this Jun 2, 2024
@z-tech z-tech deleted the dev/fix_build branch June 2, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants