Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from arkworks 3 --> 4 #10

Closed
wants to merge 9 commits into from
Closed

Update from arkworks 3 --> 4 #10

wants to merge 9 commits into from

Conversation

z-tech
Copy link

@z-tech z-tech commented Feb 20, 2024

What does this PR do?

@z-tech z-tech requested review from a team, Pratyush, mmagician and weikengchen and removed request for a team February 20, 2024 14:11
Cargo.toml Show resolved Hide resolved
@Pratyush
Copy link
Member

Nightly needs to fix this along the lines of this PR: arkworks-rs/algebra#790

@z-tech

This comment was marked as outdated.

@z-tech
Copy link
Author

z-tech commented Mar 26, 2024

@Pratyush hi, got nightly working with Giacomo's help.

I was wondering what the purpose of the no_std workflow is? I could to try to work through those errors but there's ~200 of them and I'd like to do this only if there is a specific purpose 😅. LMK if you can. Thanks.

@z-tech
Copy link
Author

z-tech commented Mar 26, 2024

@Pratyush hi, got nightly working with Giacomo's help.

I was wondering what the purpose of the no_std workflow is? I could to try to work through those errors but there's ~200 of them and I'd like to do this only if there is a specific purpose 😅. LMK if you can. Thanks.

So for a dependency chain something like ark_poly -> hashbrown -> ahash -> once_cell -> std is there some way I could fix this?

z-tech added a commit that referenced this pull request Mar 26, 2024
We'd either need a solution to the errors in #10 or we if appropriate we could just remove this check.
@z-tech z-tech mentioned this pull request Mar 26, 2024
@z-tech z-tech changed the title z-tech/update-deps Update from arkworks 3 --> 4 Mar 26, 2024
@z-tech z-tech closed this Jun 2, 2024
@z-tech z-tech deleted the z-tech/update-deps branch June 2, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants