Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SquareRootField, and move functionality to Field #422

Merged
merged 31 commits into from
Jul 14, 2022
Merged

Remove SquareRootField, and move functionality to Field #422

merged 31 commits into from
Jul 14, 2022

Commits on Feb 7, 2022

  1. Removed SquareRootField

    @solomonjoseph
    solomonjoseph committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    a36784b View commit details
    Browse the repository at this point in the history

  2. Merged from master

    @solomonjoseph
    solomonjoseph committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    a08137e View commit details
    Browse the repository at this point in the history

  3. Merge cleanup

    @solomonjoseph
    solomonjoseph committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    bf84185 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2022

  1. Reverted changes to track master

    @solomonjoseph
    solomonjoseph committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    08dc4d6 View commit details
    Browse the repository at this point in the history

  2. Added Tonelli-Shanks and Shanks sqrt algorithms for cubic extension f… 

    …ields
    @solomonjoseph
    solomonjoseph committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    a518c67 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review

    @Pratyush
    Pratyush authored Feb 8, 2022
    Configuration menu
    Copy the full SHA
    df8d67c View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2022

  1. WIP: Drafted square root algorithms for cubic extensions

    @solomonjoseph
    solomonjoseph committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    d9136e5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'sjoseph/unify_field_traits' of github.com:arkworks-rs/a… 

    …lgebra into sjoseph/unify_field_traits
    @solomonjoseph
    solomonjoseph committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    0db2b0d View commit details
    Browse the repository at this point in the history

  3. Small fix

    @solomonjoseph
    solomonjoseph committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    5475426 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2022

  1. Merge branch 'master' into unify-sqrt-and-field

    @mmagician
    mmagician committed May 25, 2022
    Configuration menu
    Copy the full SHA
    db214f6 View commit details
    Browse the repository at this point in the history

  2. Remove old imports 

    Fix
    @mmagician
    mmagician committed May 25, 2022
    Configuration menu
    Copy the full SHA
    4374ec7 View commit details
    Browse the repository at this point in the history

  3. As a first step, use Tonelli-Shanks for cubic sqrt

    @mmagician
    mmagician committed May 25, 2022
    Configuration menu
    Copy the full SHA
    ba4f0cd View commit details
    Browse the repository at this point in the history

  4. Expose attributes on CubicExtField 

    - `TWO_ADICITY`
- `TRACE_MINUS_ONE_DIV_TWO`
- `QUADRATIC_NONRESIDUE_TO_T`
needed to compute sqrt in cubic extensions
    @mmagician
    mmagician committed May 25, 2022
    Configuration menu
    Copy the full SHA
    cff8e61 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2022

  1. re-introduce SQRT_PRECOMP

    @mmagician
    mmagician committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    69a4c3b View commit details
    Browse the repository at this point in the history

  2. Call sqrt_impl macro from FpConfig square_root

    @mmagician
    mmagician committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    b6713e9 View commit details
    Browse the repository at this point in the history

  3. Test sqrt on Fq6_3over2 

    should panic with `not implemented`
    @mmagician
    mmagician committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    08cf0bd View commit details
    Browse the repository at this point in the history

  4. sqrt on Fp3 should still work

    @mmagician
    mmagician committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    36446a6 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into unify-sqrt-and-field

    @mmagician
    mmagician committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    a764fc4 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2022

  1. Mark SqrtPrecomputation enum as non-exhaustive 

    Likely to add more variants in the future
    @mmagician
    mmagician committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    28d5df6 View commit details
    Browse the repository at this point in the history

  2. Delegate sqrt precom definition to config

    @mmagician
    mmagician committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    90c9b29 View commit details
    Browse the repository at this point in the history

  3. Rename PRECOMP -> SQRT_PRECOMP

    @mmagician
    mmagician committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    cb32939 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into unify-sqrt-and-field

    @mmagician
    mmagician committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    e4c093a View commit details
    Browse the repository at this point in the history

  5. Call from_base_prime_field instead

    @mmagician
    mmagician committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    1341215 View commit details
    Browse the repository at this point in the history

  6. Remove old code

    @mmagician
    mmagician committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    5976eed View commit details
    Browse the repository at this point in the history

  7. Add default impl of sqrt

    @Pratyush
    Pratyush committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    40be9d0 View commit details
    Browse the repository at this point in the history

  8. Delegate SQRT_PRECOMP to FpConfig

    @mmagician
    mmagician committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    287cf8d View commit details
    Browse the repository at this point in the history

  9. Add comments and sort definitions

    @mmagician
    mmagician committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    bbb8883 View commit details
    Browse the repository at this point in the history

  10. Move SQRT_PRECOMP to MontConfig

    @Pratyush
    Pratyush committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    5cd329c View commit details
    Browse the repository at this point in the history

  11. Remove sqrt_impl macro

    @Pratyush
    Pratyush committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    d2434f3 View commit details
    Browse the repository at this point in the history

  12. fmt

    @mmagician
    mmagician committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    63982ec View commit details
    Browse the repository at this point in the history

  13. Update CHANGELOG

    @Pratyush
    Pratyush committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    ef0262d View commit details
    Browse the repository at this point in the history