Refactor(eos_cli_config_gen): Rearrange the eos-cli config for vlan-interfaces to match with EOS
#4488
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,15 +10,15 @@ interface Vlan24 | |
| ipv6 address 1b11:3a00:22b0:6::15/64 | ||
| ipv6 nd managed-config-flag | ||
| ipv6 nd prefix 1b11:3a00:22b0:6::/64 infinite infinite no-autoconfig | ||
| ip address virtual 10.10.24.1/24 | ||
| ipv6 virtual-router address 1b11:3a00:22b0:6::1 | ||
| ! | ||
| interface Vlan25 | ||
| description SVI Description | ||
| no shutdown | ||
| ipv6 address 1b11:3a00:22b0:16::16/64 | ||
| ipv6 virtual-router address 1b11:3a00:22b0:16::14 | ||
| ipv6 virtual-router address 1b11:3a00:22b0:16::15 | ||
| ! | ||
| interface Vlan41 | ||
| description SVI Description | ||
|
|
@@ -90,17 +90,17 @@ interface Vlan75 | |
| multicast ipv6 boundary ff00::/16 out | ||
| multicast ipv6 boundary ff01::/16 out | ||
| multicast ipv4 static | ||
|
There was a problem hiding this comment. Key-id order There was a problem hiding this comment. There was a problem hiding this comment. There was a problem hiding this comment. About the isis authentication key-id order the logic is like it will first sort the isis both type level key-ids then lervel-1 and then level-2 so we will see the order difference here. There was a problem hiding this comment.
We are already sorting base on address but EOS sorting base on vrf and none vrf destinations There was a problem hiding this comment.
this ip nat is comes from interface-ip-nat.j2 so we can check there only |
||
| ip address virtual 10.10.75.1/24 | ||
| ipv6 virtual-router address 1b11:3a00:22b0:1000::1 | ||
|
There was a problem hiding this comment. There was a problem hiding this comment. already user natural sort on boundary address and as per sort ff00 comes first then ff01 but EOS do just opposite |
||
| ! | ||
| interface Vlan81 | ||
| description IPv6 Virtual Address | ||
| vrf Tenant_C | ||
| ipv6 enable | ||
| ip address virtual 10.10.81.1/24 | ||
| ipv6 address virtual fc00:10:10:81::1/64 | ||
| ipv6 address virtual fc00:10:11:81::1/64 | ||
| ipv6 address virtual fc00:10:12:81::1/64 | ||
| ! | ||
| interface Vlan83 | ||
| description SVI Description | ||
|
|
@@ -115,8 +115,8 @@ interface Vlan83 | |
| interface Vlan84 | ||
| description SVI Description | ||
| arp gratuitous accept | ||
| ip address 10.10.84.1/24 | ||
| arp monitor mac-address | ||
| isis enable EVPN_UNDERLAY | ||
| isis authentication mode sha key-id 2 rx-disabled | ||
| isis authentication key 0 password | ||
|
|
@@ -125,20 +125,20 @@ interface Vlan84 | |
| ! | ||
| interface Vlan85 | ||
| description SVI Description | ||
| ip address 10.10.84.1/24 | ||
| arp cache dynamic capacity 50000 | ||
| bfd interval 500 min-rx 500 multiplier 5 | ||
| bfd echo | ||
| isis enable EVPN_UNDERLAY | ||
| isis authentication mode sha key-id 2 | ||
| isis authentication key 0 password | ||
| ! | ||
| interface Vlan86 | ||
| description SVI Description | ||
| ip address 10.10.83.1/24 | ||
| ip attached-host route export 10 | ||
| isis enable EVPN_UNDERLAY | ||
| isis authentication mode shared-secret profile profile1 algorithm sha-1 rx-disabled | ||
| ! | ||
| interface Vlan87 | ||
| description SVI Description | ||
|
|
@@ -177,51 +177,51 @@ interface Vlan89 | |
| multicast ipv6 static | ||
| pim ipv4 sparse-mode | ||
| pim ipv4 local-interface Loopback0 | ||
| ip address virtual 10.10.144.3/20 | ||
| ipv6 virtual-router address 1b11:3a00:22b0:5200::3 | ||
| ! | ||
| interface Vlan90 | ||
| description SVI Description | ||
| ip address 10.10.83.1/24 | ||
| ip attached-host route export | ||
| isis enable EVPN_UNDERLAY | ||
| isis authentication mode shared-secret profile profile2 algorithm sha-1 level-1 | ||
| isis authentication mode shared-secret profile profile1 algorithm sha-256 level-2 | ||
| ! | ||
| interface Vlan91 | ||
| description PBR Description | ||
| shutdown | ||
| service-policy type pbr input MyServicePolicy | ||
| isis enable EVPN_UNDERLAY | ||
| isis authentication mode md5 level-1 | ||
| isis authentication mode text level-2 | ||
| isis authentication key 0 password level-1 | ||
| isis authentication key 0 password level-2 | ||
| ! | ||
| interface Vlan92 | ||
| description SVI Description | ||
| ip proxy-arp | ||
| ip address 10.10.92.1/24 | ||
| ip directed-broadcast | ||
| isis enable EVPN_UNDERLAY | ||
| isis authentication mode shared-secret profile profile2 algorithm sha-1 rx-disabled level-1 | ||
| isis authentication mode shared-secret profile profile1 algorithm sha-256 rx-disabled level-2 | ||
| ! | ||
| interface Vlan110 | ||
| description PVLAN Primary with vlan mapping | ||
| no shutdown | ||
| pvlan mapping 111-112 | ||
| vrf Tenant_A | ||
| ip address 10.0.101.1/24 | ||
| multicast ipv4 boundary ACL_MULTICAST out | ||
| multicast ipv6 source route export 20 | ||
| multicast ipv4 static | ||
| ! | ||
| interface Vlan333 | ||
| description Multiple VRIDs and tracking | ||
| no shutdown | ||
| ip address 192.0.2.2/25 | ||
| arp aging timeout 180 | ||
| ipv6 enable | ||
| ipv6 address 2001:db8:333::2/64 | ||
| ipv6 address fe80::2/64 link-local | ||
|
|
@@ -286,8 +286,8 @@ interface Vlan501 | |
| interface Vlan667 | ||
| description Multiple VRIDs | ||
| no shutdown | ||
| ip address 192.0.2.2/25 | ||
| arp aging timeout 180 | ||
| ipv6 enable | ||
| ipv6 address 2001:db8:667::2/64 | ||
| ipv6 address fe80::2/64 link-local | ||
|
|
@@ -318,8 +318,8 @@ interface Vlan1002 | |
| ! | ||
| interface Vlan2001 | ||
| description SVI Description | ||
| logging event link-status | ||
| vrf Tenant_B | ||
| ip address virtual 10.2.1.1/24 | ||
| comment | ||
| Comment created from eos_cli under vlan_interfaces.Vlan2001 | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IP order
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The EOS is not sorting as natural sort here. If you see 239.0.0.1 then it should come before to 239.0.0.2 but not happening actually