Refactor(eos_cli_config_gen): Add support for ingress in system.control_plane.ipv4/6_access_group #4481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
role: eos_cli_config_gen
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4481
# Activate the virtual environment
source test-avd-pr-4481/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Vibhu-gslab/avd.git@ingress#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Vibhu-gslab/avd.git#/ansible_collections/arista/avd/,ingress --force
# Optional: Install AVD examples
cd test-avd-pr-4481
ansible-playbook arista.avd.install_examples |
Vibhu-gslab
changed the title
Vibhu-gslab
force-pushed
the
ingress
branch
from
c3a5661
to
b0e17eb
Compare
MaheshGSLAB
reviewed
Sep 17, 2024
| @@ -36,6 +36,10 @@ keys: | |||
| type: str | |||
| convert_types: | |||
| - int | |||
| description: "'vrf' and 'ingress_default' are mutual exclusive." | |||
| ingress_default: | |||
There was a problem hiding this comment.
I think we should have two option under ingress i.e. default and enabled.
Because we can have vrf with ingress but without default.
system control-plane
ip access-group ingress default acl4_4
ip access-group acl4_3 in
ip access-group ingress vrf mahesh in <-----------
ip access-group acl4_2 vrf red in
ip access-group acl4_2 vrf red_1 in
ip access-group acl4_5 vrf red_3 in
ip access-group ingress vrf red_4 in
There was a problem hiding this comment.
or you can add the description for acl_name to use ingress as acl since it is required key
There was a problem hiding this comment.
Added description.
| @@ -20,20 +20,28 @@ system control-plane | |||
| {% endif %} | |||
| {# control_plane access_groups ipv4 #} | |||
| {% for acl_set in system.control_plane.ipv4_access_groups | arista.avd.natural_sort %} | |||
There was a problem hiding this comment.
ipv4_access_groups is list of dicts so we should have the key name base on we need to sort but again there is no required key so we will have issue. Can you please check then do we need to remove sorting here?
Vibhu-gslab
force-pushed
the
ingress
branch
from
b0e17eb
to
ae22994
Compare
…l_plane.ipv4/6_access_group
Vibhu-gslab
force-pushed
the
ingress
branch
from
ae22994
to
b6f6e0f
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Add support for ingress in system.control_plane.ipv4/6_access_group
Related Issue(s)
Fixes #4467
Component(s) name
arista.avd.eos_cli_config_genHow to test
CI
Checklist
Repository Checklist