-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Add switchport 'tap' and 'tool' mode config to the ethernet and port-channel interfaces #4174
base: devel
Are you sure you want to change the base?
Feat(eos_cli_config_gen): Add switchport 'tap' and 'tool' mode config to the ethernet and port-channel interfaces #4174
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4174
# Activate the virtual environment
source test-avd-pr-4174/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@switchport_tap_tool#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,switchport_tap_tool --force
# Optional: Install AVD examples
cd test-avd-pr-4174
ansible-playbook arista.avd.install_examples |
4737324
to
9cc2279
Compare
0dbd7c7
to
2302af9
Compare
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/ethernet-interfaces.md
Show resolved
Hide resolved
identity: | ||
|
||
# Tap port ID tag. | ||
port_id: <int; 1-4094> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the cli is bit odd for this option
wan1-dc1(config-if-Et1)#switchport tap identity ?
<1-4094> Tap port VLAN ID tag
<1-65535> Tap port extended ID
wan1-dc1(config-if-Et1)#switchport tap identity 65533 ?
<cr>
wan1-dc1(config-if-Et1)#switchport tap identity 4094 ?
inner Configure inner tap port ID tag
<cr>
wan1-dc1(config-if-Et1)#switchport tap identity 4095 ?
<cr>
We might need to add the condtion of greater then 4094
@gmuloc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to check more
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me it is like this - [EOS 4.30]
s1-leaf2(config-if-Et1)#switchport tap identity ?
<1-4094> Tap port ID tag
s1-leaf2(config-if-Et1)#switchport tap identity 10 ?
inner Configure inner tap port ID tag
<cr>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If tap identity is greater than 4094 then it shows internal error.
s1-spine1(config-if-Et1)#switchport tap identity 4092
s1-spine1(config-if-Et1)#show active
interface Ethernet1
switchport tap identity 4092
switchport tap mac-address dest 00:01:00:01:00:01 src 00:02:00:02:00:02
switchport tap encapsulation vxlan strip
switchport tap encapsulation gre destination 1.1.1.1 source 2.2.2.2 protocol 0xad9c feature header length 3 strip
switchport tap allowed vlan 10-20
switchport tap default nexthop-group aaaa adfs asd asdfs ffr
switchport tap default interface Ethernet3
switchport tap default interface Ethernet4
switchport tap default interface Recirc-Channel4
s1-spine1(config-if-Et1)#switchport tap identity 4092 ?
inner Configure inner tap port ID tag
<cr>
s1-spine1(config-if-Et1)#switchport tap identity 65535 ?
<cr>
s1-spine1(config-if-Et1)#switchport tap identity 65535
s1-spine1(config-if-Et1)#show active
% Internal error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are VLAN IDs (a.k.a. VLAN tags) so I think we should use
identity:
# Tap port VLAN ID or extended ID
id: <int; 1-65535>
# Tap port inner VLAN ID. Only applicable if `id` is a VLAN ID between 1-4094.
inner_vlan: <int; 1-4094>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can try to investigate the extended IDs. They may be platform dependent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the extended ID is part of a DzGRE feature only available on 7280R3
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/ethernet-interfaces.md
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/ethernet-interfaces.md
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/ethernet-interfaces.md
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/ethernet-interfaces.md
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/ethernet-interfaces.md
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/ethernet-interfaces.md
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/ethernet-interfaces.md
Show resolved
Hide resolved
...lections/arista/avd/molecule/eos_cli_config_gen/intended/configs/port-channel-interfaces.cfg
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ethernet_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
06cbda0
to
8e90dbc
Compare
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ethernet_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ethernet_interfaces.schema.yml
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ethernet_interfaces.schema.yml
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ethernet_interfaces.schema.yml
Show resolved
Hide resolved
...lections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/ethernet-interfaces.md
Outdated
Show resolved
Hide resolved
0c2451f
to
bb0d566
Compare
bb0d566
to
7e79986
Compare
for more information, see https://pre-commit.ci
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
for more information, see https://pre-commit.ci
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/ethernet-interfaces.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ethernet_interfaces.schema.yml
Show resolved
Hide resolved
… switchport.tap.encapsulation.gre
6c31022
to
e1c2fe3
Compare
Quality Gate passedIssues Measures |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
6d93319
to
af4cb43
Compare
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Quality Gate passedIssues Measures |
Change Summary
Add switchport 'tap' and 'tool' mode config to the interfaces
Related Issue(s)
Fixes #
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Add schema, template and tests for
switchport.tap
andswitchport.tool
in interfaces.How to test
Molecule test added. Test in EOS CLI.
Checklist
User Checklist
Repository Checklist