Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Redo the model for additional-paths in BGP #3730

Draft
wants to merge 51 commits into
base: devel
Choose a base branch
from
Draft

Feat(eos_cli_config_gen): Redo the model for additional-paths in BGP #3730

wants to merge 51 commits into from
+1,442 −639

Conversation

laxmikantchintakindi
Copy link
Contributor

@laxmikantchintakindi laxmikantchintakindi commented Mar 11, 2024 •
edited
Loading

Change Summary

Redo the model for additional-paths in BGP to reduce number of key-value pairs and avoid repeated use of block of code using defs.

Related Issue(s)

Fixes #3279

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Enhancing code by replacing multiple key-value pairs with boolean values with the help of valid_values key.
Using defs to avoid repeated use of a block of code.

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Mar 11, 2024
@laxmikantchintakindi laxmikantchintakindi marked this pull request as ready for review March 11, 2024 11:07
@laxmikantchintakindi laxmikantchintakindi marked this pull request as draft March 11, 2024 11:07
@ClausHolbechArista
Copy link
Contributor

This will break existing deployments since you are changing an existing model in a non-backwards-compatible way.

@laxmikantchintakindi
Copy link
Contributor Author

This changes are kept hold till AVD5.0 release.

@github-actions github-actions bot added the state: conflict PR with conflict label Apr 17, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@ClausHolbechArista ClausHolbechArista added this to the v5.0.0 milestone May 2, 2024
@ClausHolbechArista ClausHolbechArista added data model change Change to existing data model breaking change labels May 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024

This PR is stale because it has been open 30 days with no activity. The PR will be reviewed by a maintainer and may be closed

@github-actions github-actions bot removed the state: conflict PR with conflict label Aug 26, 2024
@github-actions GitHub Actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed role: eos_cli_config_gen issue related to eos_cli_config_gen role state: Documentation role Updated labels Aug 26, 2024
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: Documentation role Updated and removed state: stale labels Aug 26, 2024
Shivani-gslab
Shivani-gslab requested changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@Shivani-gslab Shivani-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the porting-guide for this breaking change

python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/defs_additional_paths.schema.yml Outdated Show resolved Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/defs_additional_paths.schema.yml Outdated Show resolved Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/router-bgp.j2 Outdated Show resolved Hide resolved
@github-actions github-actions bot removed role: eos_validate_state role: eos_designs issue related to eos_designs role state: conflict PR with conflict labels Sep 27, 2024
@github-actions GitHub Actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot added the state: conflict PR with conflict label Sep 27, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

MaheshGSLAB
MaheshGSLAB reviewed Sep 27, 2024
View reviewed changes
...n-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/defs_bgp_additional_paths.schema.yml Show resolved Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/router-bgp.j2 Outdated Show resolved Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/router-bgp.j2 Outdated Show resolved Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/router-bgp.j2 Outdated Show resolved Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/router-bgp.j2 Outdated Show resolved Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/router-bgp.j2 Outdated Show resolved Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/router-bgp.j2 Outdated Show resolved Hide resolved
...e_collections/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/router-bgp-evpn.yml Outdated Show resolved Hide resolved
MaheshGSLAB
MaheshGSLAB reviewed Sep 27, 2024
View reviewed changes
Copy link
Contributor

@MaheshGSLAB MaheshGSLAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the logic for disabled and disabled any for merged BGP LU

@github-actions GitHub Actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the state: conflict PR with conflict label Sep 27, 2024
@MaheshGSLAB MaheshGSLAB requested review from a team September 30, 2024 09:20
@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review September 30, 2024 09:21
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ClausHolbechArista ClausHolbechArista marked this pull request as draft September 30, 2024 10:35
@ClausHolbechArista
Copy link
Contributor

Waiting for #4519. After that has merged we should update the root bgp add-path and the bgp labeled-unitcast add-path with the same changes in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaheshGSLAB MaheshGSLAB MaheshGSLAB approved these changes

@Shivani-gslab Shivani-gslab Shivani-gslab approved these changes

@Vibhu-gslab Vibhu-gslab Awaiting requested review from Vibhu-gslab

@ClausHolbechArista ClausHolbechArista Awaiting requested review from ClausHolbechArista

Assignees

@laxmikantchintakindi laxmikantchintakindi

Labels
breaking change data model change Change to existing data model role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: documentation Improvements or additions to documentation
Projects
None yet
Milestone
v5.0.0
Development

Successfully merging this pull request may close these issues.

Refactor(eos_cli_config_gen)!: Redo the model for additional-paths in BGP
5 participants
@laxmikantchintakindi @ClausHolbechArista @Vibhu-gslab @MaheshGSLAB @Shivani-gslab