feat: Forward ports #182
Merged
feat: Forward ports #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced `Field` trait with `Sync` in various modules for the `Poseidon2WideChip` implementation and friends, thereby updating associated dependencies. - In the `fri_fold` module, updated functions and methods to support the new interface and constraints with revised struct and replaced `Field` trait with `Sync`,
- Renamed package from `sp1-recursion-gnark-cli` to `sphinx-recursion-gnark-cli` - Updated dependency from `sp1-recursion-gnark-ffi` to `sphinx-recursion-gnark-ffi` - Included macOS-specific linking for CoreFoundation and Security frameworks in gnark-ffi package
- Enhanced error handling across three critical go files in recursion/gnark-ffi, ensuring each function returns an error along with its intended output if any error occurs. - Improved `randomPolynomial` function to return an error along with the polynomial and added necessary error checks. - Improved safety by adding error handling for `SetString` and `SetRandom` operations, the program will now terminate in case of any error. - Added error handling for critical function calls, such as `os.MkdirAll` and `vk.ExportSolidity` in build.go. - Strengthened guard against unexpected panic conditions in `prove.go` by enabling error handling for `ReadFrom` methods for the R1CS, proving key, and verifier key.
- Added a step in the GitHub workflow to install the `sphinx-recursion-gnark-cli` for integration testing. - Prepared for future testing capabilities by adding a note for `test-plonk-bn254`, pending CLI readiness.
- Introduced cross-platform support for the Go build command in the gnark-ffi's build.rs script. - Enhanced detection of the current operating system to set the appropriate GOOS environment variable.
- Replaced static type `F` with generic type parameter `T` across multiple methods in `MultiChip` struct, - this should lead to better compatibility with upstream.
wwared
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the initial, non-controversial fragment of #164
This ports the following upstream PRs:
This should not require companion PRs