Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Forward ports #150

Merged
merged 35 commits into from
Aug 19, 2024
Merged

feat: Forward ports #150

merged 35 commits into from
Aug 19, 2024

Conversation

huitseeker
Copy link
Member

@huitseeker huitseeker commented Aug 14, 2024

This ports the following upstream PRs and pushes us halfway to v.1.0.0-rc.1:

Note

This will need companion PRs.

Light client PR: argumentcomputer/zk-light-clients#161
Loam PR: https://github.com/argumentcomputer/loam/pull/214
Sphinx-contracts PR: argumentcomputer/sphinx-contracts#2

@wwared
Copy link
Member

wwared commented Aug 16, 2024

@huitseeker: Should I overwrite the S3 circuit artifacts for v1.0.8-testnet with the ones generated from this PR? Or do we want to update SPHINX_CIRCUIT_VERSION to some interim temporary value in this PR? (v1.0.9-testnet? pre-v1.0.0-rc.1? I don't know). Ideally, going forward, we would use version numbers that are independent from and can't be confused with upstream's version numbers

EDIT: I've finished reviewing the changes, everything looks good! I'm doing some more full plonk recursion tests to double-check the argumentcomputer/zk-light-clients#161 changes before I approve

Copy link
Member

@wwared wwared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm overwriting the v1.0.8-testnet artifacts with the ones from this PR, and everything is good to go!

wwared added a commit to argumentcomputer/sphinx-contracts that referenced this pull request Aug 19, 2024
@wwared wwared merged commit 7574ef9 into dev Aug 19, 2024
6 of 9 checks passed
@wwared wwared deleted the forward_ports_43 branch August 19, 2024 14:19
wwared added a commit to argumentcomputer/sphinx-contracts that referenced this pull request Aug 19, 2024
* feat: Update contracts to v1.0.8-testnet

Companion to argumentcomputer/sphinx#150

* fix: Remove VKEY_HASH

* chore: forge fmt

---------

Co-authored-by: wwared <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.